Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added policy_document on verified access endpoint resource #34264

Conversation

DanielRieske
Copy link
Contributor

Description

This PR adds the policy_document argument on the aws_verifiedaccess_endpoint resource.

This makes it possible to upload a policy to the endpoint resource.

Relations

Closes #34246

References

Output from Acceptance Testing

make testacc TESTS=TestAccVerifiedAccessEndpoint_policy PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccessEndpoint_policy'  -timeout 360m
=== RUN   TestAccVerifiedAccessEndpoint_policyDocument
=== PAUSE TestAccVerifiedAccessEndpoint_policyDocument
=== CONT  TestAccVerifiedAccessEndpoint_policyDocument
--- PASS: TestAccVerifiedAccessEndpoint_policyDocument (1099.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1102.133s
make testacc TESTS=TestAccVerifiedAccessEndpoint_ PKG=ec2      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccessEndpoint_'  -timeout 360m
=== RUN   TestAccVerifiedAccessEndpoint_basic
=== PAUSE TestAccVerifiedAccessEndpoint_basic
=== RUN   TestAccVerifiedAccessEndpoint_networkInterface
=== PAUSE TestAccVerifiedAccessEndpoint_networkInterface
=== RUN   TestAccVerifiedAccessEndpoint_tags
=== PAUSE TestAccVerifiedAccessEndpoint_tags
=== RUN   TestAccVerifiedAccessEndpoint_disappears
=== PAUSE TestAccVerifiedAccessEndpoint_disappears
=== RUN   TestAccVerifiedAccessEndpoint_policyDocument
=== PAUSE TestAccVerifiedAccessEndpoint_policyDocument
=== CONT  TestAccVerifiedAccessEndpoint_basic
=== CONT  TestAccVerifiedAccessEndpoint_disappears
=== CONT  TestAccVerifiedAccessEndpoint_policyDocument
=== CONT  TestAccVerifiedAccessEndpoint_tags
=== CONT  TestAccVerifiedAccessEndpoint_networkInterface
--- PASS: TestAccVerifiedAccessEndpoint_policyDocument (1131.99s)
--- PASS: TestAccVerifiedAccessEndpoint_networkInterface (1169.14s)
--- PASS: TestAccVerifiedAccessEndpoint_tags (1173.21s)
--- PASS: TestAccVerifiedAccessEndpoint_basic (1215.44s)
--- PASS: TestAccVerifiedAccessEndpoint_disappears (1374.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1377.070s

Copy link

github-actions bot commented Nov 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. labels Nov 4, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 4, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2023
@ewbankkit ewbankkit self-assigned this Dec 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 22, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessEndpoint_ -timeout 360m
=== RUN   TestAccVerifiedAccessEndpoint_basic
=== PAUSE TestAccVerifiedAccessEndpoint_basic
=== RUN   TestAccVerifiedAccessEndpoint_networkInterface
=== PAUSE TestAccVerifiedAccessEndpoint_networkInterface
=== RUN   TestAccVerifiedAccessEndpoint_tags
=== PAUSE TestAccVerifiedAccessEndpoint_tags
=== RUN   TestAccVerifiedAccessEndpoint_disappears
=== PAUSE TestAccVerifiedAccessEndpoint_disappears
=== RUN   TestAccVerifiedAccessEndpoint_policyDocument
=== PAUSE TestAccVerifiedAccessEndpoint_policyDocument
=== CONT  TestAccVerifiedAccessEndpoint_basic
=== CONT  TestAccVerifiedAccessEndpoint_disappears
--- PASS: TestAccVerifiedAccessEndpoint_basic (1377.40s)
=== CONT  TestAccVerifiedAccessEndpoint_policyDocument
--- PASS: TestAccVerifiedAccessEndpoint_disappears (1465.85s)
=== CONT  TestAccVerifiedAccessEndpoint_tags
--- PASS: TestAccVerifiedAccessEndpoint_policyDocument (1191.03s)
=== CONT  TestAccVerifiedAccessEndpoint_networkInterface
--- PASS: TestAccVerifiedAccessEndpoint_tags (1105.74s)
--- PASS: TestAccVerifiedAccessEndpoint_networkInterface (1109.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	3684.264s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c43f584 into hashicorp:main Dec 22, 2023
61 of 62 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 22, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Policy document on aws_verifiedaccess_endpoint
3 participants