-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/sagemaker_feature_group - add args #34283
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMakerFeatureGroup_serial' PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMakerFeatureGroup_serial -timeout 360m
=== RUN TestAccSageMakerFeatureGroup_serial
=== PAUSE TestAccSageMakerFeatureGroup_serial
=== CONT TestAccSageMakerFeatureGroup_serial
=== RUN TestAccSageMakerFeatureGroup_serial/offlineConfig_createCatalog
=== RUN TestAccSageMakerFeatureGroup_serial/offlineConfig_providedCatalog
=== RUN TestAccSageMakerFeatureGroup_serial/onlineConfig_TTLDuration
=== RUN TestAccSageMakerFeatureGroup_serial/basic
=== RUN TestAccSageMakerFeatureGroup_serial/storageType
=== RUN TestAccSageMakerFeatureGroup_serial/multipleFeatures
=== RUN TestAccSageMakerFeatureGroup_serial/offlineConfig_format
feature_group_test.go:342: Step 1/2 error: Error running apply: exit status 1
Error: waiting for SageMaker Feature Group (tf-acc-test-3879383729371267353) to create: unexpected state 'CreateFailed', wanted target 'Created'. last error: Exception: {User: arn:aws:sts::123456789012:assumed-role/tf-acc-test-3879383729371267353/SageMakerFeatureStore4655599647252957269 is not authorized to perform: glue:GetTable on resource: arn:aws:glue:us-west-2:123456789012:catalog because no identity-based policy allows the glue:GetTable action (Service: Glue, Status Code: 400, Request ID: b9e1000a-1a3d-4ab1-b688-ba79fd4f73c9)}. Please ensure given RoleArn has 'AmazonSageMakerFeatureStoreAccess' managed policy attached, with access to get and update Glue table in the AWS account, read and write Iceberg objects in S3, with principal 'sagemaker.amazonaws.com' as a trusted entity. If a KMS Key is provided for the Offline Store, also ensure that RoleArn is allowed to perform 'kms:GenerateDataKey' and 'kms:Decrypt' actions on it.
with aws_sagemaker_feature_group.test,
on terraform_plugin_test.tf line 47, in resource "aws_sagemaker_feature_group" "test":
47: resource "aws_sagemaker_feature_group" "test" {
=== RUN TestAccSageMakerFeatureGroup_serial/onlineConfigSecurityConfig
=== RUN TestAccSageMakerFeatureGroup_serial/tags
=== RUN TestAccSageMakerFeatureGroup_serial/description
=== RUN TestAccSageMakerFeatureGroup_serial/disappears
=== RUN TestAccSageMakerFeatureGroup_serial/offlineConfig_basic
--- FAIL: TestAccSageMakerFeatureGroup_serial (1676.91s)
--- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_createCatalog (86.04s)
--- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_providedCatalog (83.02s)
--- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfig_TTLDuration (65.84s)
--- PASS: TestAccSageMakerFeatureGroup_serial/basic (49.24s)
--- PASS: TestAccSageMakerFeatureGroup_serial/storageType (934.58s)
--- PASS: TestAccSageMakerFeatureGroup_serial/multipleFeatures (49.47s)
--- FAIL: TestAccSageMakerFeatureGroup_serial/offlineConfig_format (83.77s)
--- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfigSecurityConfig (49.85s)
--- PASS: TestAccSageMakerFeatureGroup_serial/tags (82.40s)
--- PASS: TestAccSageMakerFeatureGroup_serial/description (39.81s)
--- PASS: TestAccSageMakerFeatureGroup_serial/disappears (68.59s)
--- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_basic (84.29s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 1682.568s
FAIL
make: *** [testacc] Error 1
Failure is unrelated to this change.
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #32901
References
Output from Acceptance Testing