Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_ec2_capacity_reservation creation failure not detected creation loops until timeout #34345

Closed
Deku-shrub opened this issue Nov 10, 2023 · 4 comments · Fixed by #36754 or #37142
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@Deku-shrub
Copy link
Contributor

Deku-shrub commented Nov 10, 2023

Terraform Core Version

1.6.3-dev

AWS Provider Version

5.20.1

Affected Resource(s)

aws_ec2_capacity_reservation

Expected Behavior

Terraform should poll the capacity group creation status and fail the resource creation if the resource did not create and showed status 'failed'.

Actual Behavior

Terraform appears to silently retry the creation behaviour indefinitely without returning any information on the creation status or retrying behaviour if it gets 'Insufficient capacity' as a response.

Relevant Error/Panic Output Snippet

{"@level":"info","@message":"Terraform 1.6.3","@module":"terraform.ui","@timestamp":"2023-11-10T10:00:02.313667Z","terraform":"1.6.3","type":"version","ui":"1.2"}
{"@level":"info","@message":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]: Plan to create","@module":"terraform.ui","@timestamp":"2023-11-10T10:00:04.723090Z","change":{"resource":{"addr":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","module":"","resource":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","implied_provider":"aws","resource_type":"aws_ec2_capacity_reservation","resource_name":"connectivity_instance_reservation","resource_key":0},"action":"create"},"type":"planned_change"}
{"@level":"info","@message":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]: Creating...","@module":"terraform.ui","@timestamp":"2023-11-10T10:00:06.004090Z","hook":{"resource":{"addr":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","module":"","resource":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","implied_provider":"aws","resource_type":"aws_ec2_capacity_reservation","resource_name":"connectivity_instance_reservation","resource_key":0},"action":"create"},"type":"apply_start"}
{"@level":"info","@message":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]: Still creating... [10s elapsed]","@module":"terraform.ui","@timestamp":"2023-11-10T10:00:16.004694Z","hook":{"resource":{"addr":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","module":"","resource":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","implied_provider":"aws","resource_type":"aws_ec2_capacity_reservation","resource_name":"connectivity_instance_reservation","resource_key":0},"action":"create","elapsed_seconds":10},"type":"apply_progress"}

... much later ...

{"addr":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","module":"","resource":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","implied_provider":"aws","resource_type":"aws_ec2_capacity_reservation","resource_name":"connectivity_instance_reservation","resource_key":0},"action":"create","elapsed_seconds":1960},"type":"apply_progress"}
{"@level":"info","@message":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]: Still creating... [32m50s elapsed]","@module":"terraform.ui","@timestamp":"2023-11-10T10:32:56.181499Z","hook":{"resource":{"addr":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","module":"","resource":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","implied_provider":"aws","resource_type":"aws_ec2_capacity_reservation","resource_name":"connectivity_instance_reservation","resource_key":0},"action":"create","elapsed_seconds":1970},"type":"apply_progress"}
{"@level":"info","@message":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]: Still creating... [33m0s elapsed]","@module":"terraform.ui","@timestamp":"2023-11-10T10:33:06.181859Z","hook":{"resource":{"addr":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","module":"","resource":"aws_ec2_capacity_reservation.connectivity_instance_reservation[0]","implied_provider":"aws","resource_type":"aws_ec2_capacity_reservation","resource_name":"connectivity_instance_reservation","resource_key":0},"action":"create","elapsed_seconds":1980},"type":"apply_progress"}

Terraform Configuration Files

resource "aws_ec2_capacity_reservation" "connectivity_instance_reservation" {
  instance_count      = 1
  instance_type       = "a1.medium" # this small instance type seems more likely to error
  instance_platform   = "Linux/UNIX"
  availability_zone   = <az>
  placement_group_arn = <placement group arn> # likely having this makes the issue more likely
}

Steps to Reproduce

Create a capacity reservation in a narrow type/zone/placement group combination and the reservation will fail based on the example resource.

Terraform rather than failing will retry until timeout.

AWS console screenshot showing the multiple creation attempts.
Screenshot from 2023-11-10 10-39-09

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

@Deku-shrub Deku-shrub added the bug Addresses a defect in current functionality. label Nov 10, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Nov 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 10, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2023
Copy link

github-actions bot commented Jul 5, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.58.0 milestone Jul 5, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
2 participants