feat: Add enable_local_write_forwarding arg to aws_rds_cluster

[acwwat]

Description

This PR is for adding a new enable_local_write_forwarding argument to the aws_rds_cluster resource to support the new Aurora MySQL local write forwarding feature.

Relations

Closes #34346.
Closes #36471.

References

• CreateDBCluster provides the description of the new EnableLocalWriteForwarding parameter.
• Using local write forwarding in an Amazon Aurora MySQL DB cluster provides more info about the feature, as mentioned by the creator of the issue.

Output from Acceptance Testing

antw@U-UQPXPV4N2NIW:~/git/terraform-provider-aws$ make testacc TESTS=TestAccRDSCluster_localWriteForwarding PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_localWriteForwarding'  -timeout 360m
=== RUN   TestAccRDSCluster_localWriteForwarding
=== PAUSE TestAccRDSCluster_localWriteForwarding
=== CONT  TestAccRDSCluster_localWriteForwarding
--- PASS: TestAccRDSCluster_localWriteForwarding (191.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        192.142s
antw@U-UQPXPV4N2NIW:~/git/terraform-provider-aws$ 

Pending full acceptance test run...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[acwwat]

I need some help from one of the maintainers to run the full acceptance test suite for this resource. Unfortunately I am not able to readily request for a quota increase for the # of VPCs, so many test cases are failing at step 1. Thanks and let me know if you need more info.

[quentinlacrouts]

Hello,

Any update on this ?

Thank you

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCluster_localWriteForwarding\|TestAccRDSCluster_basic' PKG=rds     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_localWriteForwarding\|TestAccRDSCluster_basic -timeout 360m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_localWriteForwarding
=== PAUSE TestAccRDSCluster_localWriteForwarding
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_localWriteForwarding
--- PASS: TestAccRDSCluster_basic (168.90s)
--- PASS: TestAccRDSCluster_localWriteForwarding (169.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	179.973s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.