Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate appflow resources to AWS SDK for Go v2 #34456

Merged
merged 15 commits into from
Nov 17, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 17, 2023

Description

Migrates appflow resources to AWS SDK for Go v2.

Relations

Closes #26491.
Closes #28237.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAppFlow' PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2  -run=TestAccAppFlow -timeout 360m
=== RUN   TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN   TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN   TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== PAUSE TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowConnectorProfile_basic
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_update (68.54s)
=== CONT  TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_tags (93.31s)
=== CONT  TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_disappears (47.14s)
=== CONT  TestAccAppFlowFlow_TaskProperties
--- PASS: TestAccAppFlowFlow_TaskProperties (43.46s)
=== CONT  TestAccAppFlowFlow_basic
--- PASS: TestAccAppFlowConnectorProfile_basic (260.16s)
=== CONT  TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
--- PASS: TestAccAppFlowFlow_basic (46.55s)
=== CONT  TestAccAppFlowConnectorProfile_disappears
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (64.12s)
=== CONT  TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_disappears (253.33s)
--- PASS: TestAccAppFlowConnectorProfile_update (328.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	658.891s

% make testacc TESTARGS='-run=TestAccAppFlow' PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2  -run=TestAccAppFlow -timeout 360m
=== RUN   TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN   TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN   TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== PAUSE TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowConnectorProfile_basic
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_update (68.54s)
=== CONT  TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_tags (93.31s)
=== CONT  TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_disappears (47.14s)
=== CONT  TestAccAppFlowFlow_TaskProperties
--- PASS: TestAccAppFlowFlow_TaskProperties (43.46s)
=== CONT  TestAccAppFlowFlow_basic
--- PASS: TestAccAppFlowConnectorProfile_basic (260.16s)
=== CONT  TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
--- PASS: TestAccAppFlowFlow_basic (46.55s)
=== CONT  TestAccAppFlowConnectorProfile_disappears
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (64.12s)
=== CONT  TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_disappears (253.33s)
--- PASS: TestAccAppFlowConnectorProfile_update (328.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	658.891s
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appflow Issues and PRs that pertain to the appflow service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Nov 17, 2023
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 17, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Nov 17, 2023
@ewbankkit
Copy link
Contributor Author

After fixes:

% make testacc TESTARGS='-run=TestAccAppFlowFlow_' PKG=appflow ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2  -run=TestAccAppFlowFlow_ -timeout 360m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== PAUSE TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_taskProperties
=== PAUSE TestAccAppFlowFlow_taskProperties
=== RUN   TestAccAppFlowFlow_taskUpdate
=== PAUSE TestAccAppFlowFlow_taskUpdate
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_taskUpdate
--- PASS: TestAccAppFlowFlow_basic (53.17s)
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_taskUpdate (72.56s)
=== CONT  TestAccAppFlowFlow_taskProperties
--- PASS: TestAccAppFlowFlow_taskProperties (46.72s)
=== CONT  TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
--- PASS: TestAccAppFlowFlow_update (69.65s)
=== CONT  TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_disappears (45.97s)
=== CONT  TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (67.64s)
--- PASS: TestAccAppFlowFlow_tags (91.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	265.702s

@ewbankkit ewbankkit merged commit aa02d7c into main Nov 17, 2023
@ewbankkit ewbankkit deleted the td-migrate-appflow-to-aws-sdk-v2 branch November 17, 2023 19:35
@github-actions github-actions bot added this to the v5.27.0 milestone Nov 17, 2023
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 27, 2023
Copy link

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. bug Addresses a defect in current functionality. client-connections Pertains to the AWS Client and service connections. crash Results from or addresses a Terraform crash or kernel panic. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appflow Issues and PRs that pertain to the appflow service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants