-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate aws_s3_bucket_lifecycle_configuration
and aws_s3_bucket_replication_configuration
to AWS SDK for Go v2
#34504
Conversation
…replication_configuration` and `aws_s3_bucket_lifecycle_configuration`" This reverts commit 47f1924.
Community NoteVoting for Prioritization
For Submitters
|
aws_s3_bucket_lifecycle_configuration
and aws_s3_bucket_replication_configuration
to AWS SDK for Go v2aws_s3_bucket_lifecycle_configuration
and aws_s3_bucket_replication_configuration
to AWS SDK for Go v2
… block to support automatic date-based partitioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccS3BucketReplicationConfiguration_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3BucketReplicationConfiguration_ -timeout 360m
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (1017.72s)
=== CONT TestAccS3BucketReplicationConfiguration_disappears
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock (1181.45s)
=== CONT TestAccS3BucketReplicationConfiguration_replicationTimeControl
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyPrefix (1210.01s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (1229.03s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (1244.99s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (1245.49s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (1249.81s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (1253.20s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (1253.23s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_withoutId (1262.12s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutId (1279.97s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (1421.04s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (1601.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (1603.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_withChange (1624.25s)
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_noChange (1630.56s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (1799.47s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (829.70s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (715.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (1897.95s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (1938.58s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (2084.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 2088.232s
% make testacc TESTARGS='-run=TestAccS3BucketLifecycleConfiguration_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3BucketLifecycleConfiguration_ -timeout 360m
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering (235.86s)
=== CONT TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa (243.55s)
=== CONT TestAccS3BucketLifecycleConfiguration_disappears
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules (260.88s)
=== CONT TestAccS3BucketLifecycleConfiguration_filterWithPrefix
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_noChange (262.77s)
=== CONT TestAccS3BucketLifecycleConfiguration_disableRule
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_withChange (262.82s)
=== CONT TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan
--- PASS: TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions (264.47s)
=== CONT TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_Tag (266.72s)
=== CONT TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (275.71s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan (284.13s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix (284.35s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock (290.34s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering (290.46s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix (292.51s)
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (293.91s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration (294.55s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition (295.06s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering (295.07s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix (387.38s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (156.71s)
--- PASS: TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload (417.68s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero (163.85s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange (166.24s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan (168.17s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering (507.79s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly (291.30s)
--- PASS: TestAccS3BucketLifecycleConfiguration_filterWithPrefix (273.63s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disableRule (358.50s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 624.580s
This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Following the resolution of aws/aws-sdk-go-v2#2162 we can now migrate
aws_s3_bucket_lifecycle_configuration
andaws_s3_bucket_replication_configuration
to AWS SDK for Go v2.Migration of
aws_s3_bucket
will be done after re:Invent.Relations
Relates #33654.
Relates #32976.
Closes #34518.
Output from Acceptance Testing