-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pod identity association resource #34566
feat: Add pod identity association resource #34566
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…into f-eks-pod-identity-association
@bschaatsbergen / @ewbankkit any ideas on whats missing for these errors? I'm still pretty new with the plugin framework
|
14670e3
to
1a36d83
Compare
|
1a36d83
to
f0e7f3e
Compare
% make testacc TESTARGS='-run=TestAccEKSPodIdentityAssociation_basic' PKG=eks ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSPodIdentityAssociation_basic -timeout 360m === RUN TestAccEKSPodIdentityAssociation_basic === PAUSE TestAccEKSPodIdentityAssociation_basic === CONT TestAccEKSPodIdentityAssociation_basic --- PASS: TestAccEKSPodIdentityAssociation_basic (626.40s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 638.338s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSPodIdentityAssociation_' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2 -run=TestAccEKSPodIdentityAssociation_ -timeout 360m
=== RUN TestAccEKSPodIdentityAssociation_basic
=== PAUSE TestAccEKSPodIdentityAssociation_basic
=== RUN TestAccEKSPodIdentityAssociation_disappears
=== PAUSE TestAccEKSPodIdentityAssociation_disappears
=== RUN TestAccEKSPodIdentityAssociation_tags
=== PAUSE TestAccEKSPodIdentityAssociation_tags
=== RUN TestAccEKSPodIdentityAssociation_updateRoleARN
=== PAUSE TestAccEKSPodIdentityAssociation_updateRoleARN
=== CONT TestAccEKSPodIdentityAssociation_basic
=== CONT TestAccEKSPodIdentityAssociation_tags
--- PASS: TestAccEKSPodIdentityAssociation_basic (649.14s)
=== CONT TestAccEKSPodIdentityAssociation_disappears
--- PASS: TestAccEKSPodIdentityAssociation_tags (693.67s)
=== CONT TestAccEKSPodIdentityAssociation_updateRoleARN
--- PASS: TestAccEKSPodIdentityAssociation_disappears (603.78s)
--- PASS: TestAccEKSPodIdentityAssociation_updateRoleARN (654.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 1349.519s
@bryantbiggs Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
References
Output from Acceptance Testing