Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new resource/datasource]: aws_codeguruprofiler_profiling_group #34672

Merged
merged 12 commits into from
Dec 1, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Nov 30, 2023

Description

Relations

Closes #16768

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccCodeGuruProfilerProfilingGroup_\|TestAccCodeGuruProfilerProfilingGroupDataSource_" PKG=codeguruprofiler

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codeguruprofiler/... -v -count 1 -parallel 20  -run=TestAccCodeGuruProfilerProfilingGroup_\|TestAccCodeGuruProfilerProfilingGroupDataSource_ -timeout 360m
--- PASS: TestAccCodeGuruProfilerProfilingGroup_disappears (38.95s)
--- PASS: TestAccCodeGuruProfilerProfilingGroup_basic (46.97s)
--- PASS: TestAccCodeGuruProfilerProfilingGroupDataSource_basic (64.43s)
--- PASS: TestAccCodeGuruProfilerProfilingGroup_update (70.11s)
--- PASS: TestAccCodeGuruProfilerProfilingGroup_tags (94.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeguruprofiler	97.781s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. generators Relates to code generators. labels Nov 30, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 30, 2023
Copy link

github-actions bot commented Dec 1, 2023

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@johnsonaj johnsonaj force-pushed the f-codeguruprofiler_profiling_group branch from 05435c6 to 87162b3 Compare December 1, 2023 18:11
@johnsonaj johnsonaj marked this pull request as ready for review December 1, 2023 18:31
@johnsonaj johnsonaj added new-resource Introduces a new resource. new-data-source Introduces a new data source. labels Dec 1, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS="-run=TestAccCodeGuruProfilerProfilingGroup_\|TestAccCodeGuruProfilerProfilingGroupDataSource_" PKG=codeguruprofiler
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codeguruprofiler/... -v -count 1 -parallel 20  -run=TestAccCodeGuruProfilerProfilingGroup_\|TestAccCodeGuruProfilerProfilingGroupDataSource_ -timeout 360m
=== RUN   TestAccCodeGuruProfilerProfilingGroupDataSource_basic
=== PAUSE TestAccCodeGuruProfilerProfilingGroupDataSource_basic
=== RUN   TestAccCodeGuruProfilerProfilingGroup_basic
=== PAUSE TestAccCodeGuruProfilerProfilingGroup_basic
=== RUN   TestAccCodeGuruProfilerProfilingGroup_disappears
=== PAUSE TestAccCodeGuruProfilerProfilingGroup_disappears
=== RUN   TestAccCodeGuruProfilerProfilingGroup_update
=== PAUSE TestAccCodeGuruProfilerProfilingGroup_update
=== RUN   TestAccCodeGuruProfilerProfilingGroup_tags
=== PAUSE TestAccCodeGuruProfilerProfilingGroup_tags
=== CONT  TestAccCodeGuruProfilerProfilingGroupDataSource_basic
=== CONT  TestAccCodeGuruProfilerProfilingGroup_tags
=== CONT  TestAccCodeGuruProfilerProfilingGroup_update
=== CONT  TestAccCodeGuruProfilerProfilingGroup_disappears
=== CONT  TestAccCodeGuruProfilerProfilingGroup_basic
--- PASS: TestAccCodeGuruProfilerProfilingGroup_disappears (36.94s)
--- PASS: TestAccCodeGuruProfilerProfilingGroup_basic (43.77s)
--- PASS: TestAccCodeGuruProfilerProfilingGroupDataSource_basic (60.42s)
--- PASS: TestAccCodeGuruProfilerProfilingGroup_update (66.52s)
--- PASS: TestAccCodeGuruProfilerProfilingGroup_tags (91.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codeguruprofiler   94.959s

@johnsonaj johnsonaj merged commit 64d339a into main Dec 1, 2023
74 checks passed
@johnsonaj johnsonaj deleted the f-codeguruprofiler_profiling_group branch December 1, 2023 19:56
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 1, 2023
github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codeguru profiling group resource
2 participants