Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sagemaker Studio - Add support for new jupyter lab arguments #34729

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Sagemaker Studio - Add support for new jupyter lab arguments #34729

merged 6 commits into from
Dec 5, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 5, 2023 •
edited
Loading

Description

Relations

Closes #34689
Closes #34673

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMaker_serial PKG=sagemaker

        --- PASS: TestAccSageMaker_serial/Domain/efs (541.49s)
        --- PASS: TestAccSageMaker_serial/Domain/posix (386.44s)
        --- PASS: TestAccSageMaker_serial/Domain/codeEditorAppSettings (384.93s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettings (382.32s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceStorageSettings (391.98s)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Dec 5, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Dec 5, 2023
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 5, 2023
@DrFaust92
Copy link
Collaborator Author

Ill add more arguments for space with another PR as there a lot of the content here is reused between the resources

@DrFaust92 DrFaust92 marked this pull request as ready for review December 5, 2023 00:32
ewbankkit
ewbankkit approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccSageMaker_serial/^Domain$$\|TestAccSageMaker_serial/^App$$\|TestAccSageMaker_serial/^Space$$\|TestAccSageMaker_serial/^UserProfile$$' PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/^Domain$\|TestAccSageMaker_serial/^App$\|TestAccSageMaker_serial/^Space$\|TestAccSageMaker_serial/^UserProfile$ -timeout 720m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/tags
=== RUN   TestAccSageMaker_serial/UserProfile/basic
=== RUN   TestAccSageMaker_serial/UserProfile/disappears
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig
    user_profile_test.go:244: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/App
=== RUN   TestAccSageMaker_serial/App/resourceSpecLifecycle
=== RUN   TestAccSageMaker_serial/App/space
=== RUN   TestAccSageMaker_serial/App/basic
=== RUN   TestAccSageMaker_serial/App/disappears
=== RUN   TestAccSageMaker_serial/App/tags
=== RUN   TestAccSageMaker_serial/App/resourceSpec
=== RUN   TestAccSageMaker_serial/Domain
=== RUN   TestAccSageMaker_serial/Domain/securityGroup
=== RUN   TestAccSageMaker_serial/Domain/canvas
=== RUN   TestAccSageMaker_serial/Domain/identityProviderOauthSettings
=== RUN   TestAccSageMaker_serial/Domain/code
=== RUN   TestAccSageMaker_serial/Domain/tags
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage
    domain_test.go:725: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/jupyterLabAppSettings
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/rStudioServerProAppSettings
=== RUN   TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated
=== RUN   TestAccSageMaker_serial/Domain/efs
=== RUN   TestAccSageMaker_serial/Domain/codeEditorAppSettings
=== RUN   TestAccSageMaker_serial/Domain/sharingSettings
=== RUN   TestAccSageMaker_serial/Domain/rSessionAppSettings
=== RUN   TestAccSageMaker_serial/Domain/workspaceSettings
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage
    domain_test.go:764: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/kms
=== RUN   TestAccSageMaker_serial/Domain/directDeploySettings
=== RUN   TestAccSageMaker_serial/Domain/domainSettings
=== RUN   TestAccSageMaker_serial/Domain/posix
=== RUN   TestAccSageMaker_serial/Domain/spaceStorageSettings
=== RUN   TestAccSageMaker_serial/Domain/basic
=== RUN   TestAccSageMaker_serial/Domain/modelRegisterSettings
=== RUN   TestAccSageMaker_serial/Domain/kendraSettings
=== RUN   TestAccSageMaker_serial/Domain/disappears
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/Domain/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Space
=== RUN   TestAccSageMaker_serial/Space/tags
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig
    space_test.go:170: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Space/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Space/basic
=== RUN   TestAccSageMaker_serial/Space/disappears
--- PASS: TestAccSageMaker_serial (14777.78s)
    --- PASS: TestAccSageMaker_serial/UserProfile (2122.59s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tags (262.65s)
        --- PASS: TestAccSageMaker_serial/UserProfile/basic (256.48s)
        --- PASS: TestAccSageMaker_serial/UserProfile/disappears (305.83s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (255.08s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (275.98s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (254.88s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (254.70s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (256.97s)
    --- PASS: TestAccSageMaker_serial/App (3432.69s)
        --- PASS: TestAccSageMaker_serial/App/resourceSpecLifecycle (605.42s)
        --- PASS: TestAccSageMaker_serial/App/space (539.31s)
        --- PASS: TestAccSageMaker_serial/App/basic (544.84s)
        --- PASS: TestAccSageMaker_serial/App/disappears (539.22s)
        --- PASS: TestAccSageMaker_serial/App/tags (621.15s)
        --- PASS: TestAccSageMaker_serial/App/resourceSpec (582.76s)
    --- PASS: TestAccSageMaker_serial/Domain (7635.07s)
        --- PASS: TestAccSageMaker_serial/Domain/securityGroup (286.20s)
        --- PASS: TestAccSageMaker_serial/Domain/canvas (258.52s)
        --- PASS: TestAccSageMaker_serial/Domain/identityProviderOauthSettings (260.91s)
        --- PASS: TestAccSageMaker_serial/Domain/code (267.20s)
        --- PASS: TestAccSageMaker_serial/Domain/tags (255.95s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterLabAppSettings (249.32s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings (283.52s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettings (250.92s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings (261.03s)
        --- PASS: TestAccSageMaker_serial/Domain/rStudioServerProAppSettings (291.65s)
        --- PASS: TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated (290.85s)
        --- PASS: TestAccSageMaker_serial/Domain/efs (368.47s)
        --- PASS: TestAccSageMaker_serial/Domain/codeEditorAppSettings (258.76s)
        --- PASS: TestAccSageMaker_serial/Domain/sharingSettings (259.41s)
        --- PASS: TestAccSageMaker_serial/Domain/rSessionAppSettings (262.95s)
        --- PASS: TestAccSageMaker_serial/Domain/workspaceSettings (259.57s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/kms (248.60s)
        --- PASS: TestAccSageMaker_serial/Domain/directDeploySettings (249.04s)
        --- PASS: TestAccSageMaker_serial/Domain/domainSettings (319.63s)
        --- PASS: TestAccSageMaker_serial/Domain/posix (265.22s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceStorageSettings (260.99s)
        --- PASS: TestAccSageMaker_serial/Domain/basic (270.14s)
        --- PASS: TestAccSageMaker_serial/Domain/modelRegisterSettings (248.92s)
        --- PASS: TestAccSageMaker_serial/Domain/kendraSettings (259.25s)
        --- PASS: TestAccSageMaker_serial/Domain/disappears (300.30s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (271.09s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage (326.78s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterServerAppSettings (249.88s)
    --- PASS: TestAccSageMaker_serial/Space (1587.43s)
        --- PASS: TestAccSageMaker_serial/Space/tags (262.36s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings (264.07s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig (246.61s)
        --- SKIP: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterServerAppSettings (254.96s)
        --- PASS: TestAccSageMaker_serial/Space/basic (254.43s)
        --- PASS: TestAccSageMaker_serial/Space/disappears (304.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	14783.473s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 369872a into hashicorp:main Dec 5, 2023
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.30.0
2 participants
@DrFaust92 @ewbankkit