Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for the Agentless Collector for Prometheus for EKS Clusters #34733

Closed
lorrrrrrrenzo opened this issue Dec 5, 2023 · 4 comments · Fixed by #34749
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amp Issues and PRs that pertain to the amp service.
Milestone

Comments

@lorrrrrrrenzo
Copy link

Description

AWS announced an agentless collector for Prometheus and EKS and I would like to see support for it added to Terraform.

Affected Resource(s) and/or Data Source(s)

  • aws_eks_cluster

You may also decide to create a new object to manage the Managed Prometheus/EKS relationship, like aws_eks_prometheus_collector

Potential Terraform Configuration

resource "aws_prometheus_workspace" "p8s" {
    alias = "feature_request"
    # ... other fields ...
}

resource "aws_eks_cluster" "eks_one" {
    name = "new-cluster"
    # ... other fields ...
    prometheus_collector {
        endpoint = aws_prometheus_workspace.p8s.prometheus_endpoint
        scrape_configuration = "..."
        connection_subnets = ["subnet-exampleid123", "subnet-exampleid456", "subnet-example789"]
        connection_sgs = ["sg-example12345", "sg-example67890"]
    }
}

#-----
#-----
# Alternative implementation
resource "aws_eks_cluster" "eks_two" {
    name = "alternative-new-cluster"
    # ... other fields ...
}

resource "aws_eks_prometheus_collector" "a" {
    scrape_configuration = "..."
    connection_subnets = ["subnet-exampleid123", "subnet-exampleid456", "subnet-example789"]
    connection_sgs = ["sg-example12345", "sg-example67890"]

    eks_cluster_arn = aws_eks_cluster.eks_two.arn
    managed_p8s_arn = aws_prometheus_workspace.p8s.arn
}

References

Announcement Blog Post
Setup Instructions, under "How do I get started..."

Would you like to implement a fix?

None

@lorrrrrrrenzo lorrrrrrrenzo added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/amp Issues and PRs that pertain to the amp service. service/eks Issues and PRs that pertain to the eks service. labels Dec 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 5, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2023
@andrewbcoyle
Copy link

I would love to see this, and personally I prefer the first approach of the two presented. That's basically how I imagined it working.

@ewbankkit ewbankkit removed the service/eks Issues and PRs that pertain to the eks service. label Jan 3, 2024
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 4, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amp Issues and PRs that pertain to the amp service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants