aws_elasticache_replication_group: modify before scale in

[chris-peterson]

Description

When scaling in a aws_elasticache_replication_group (i.e. reducing node count), resize after making other modifications.

This avoid an invalid parameter error in certain conditions, e.g. if reducing from 2 to 1 while also disabling multi_az_enabled and/or automatic_failover_enabled, the cluster configuration has to be applied before reducing node count (otherwise results in an error like this):

InvalidParameterValue: Must have at least 1 replica for Multi-AZ enabled Replication Group

I've left the scale out path alone to avoid issues in the other direction (e.g. enabling automatic_failover_enabled while scaling from 1 to 2)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @chris-peterson 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.