Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: New Resource aws_apprunner_start_deployment #34835

Closed
emoshaya opened this issue Dec 8, 2023 · 9 comments · Fixed by #35758
Closed

[Enhancement]: New Resource aws_apprunner_start_deployment #34835

emoshaya opened this issue Dec 8, 2023 · 9 comments · Fixed by #35758
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apprunner Issues and PRs that pertain to the apprunner service.
Milestone

Comments

@emoshaya
Copy link

emoshaya commented Dec 8, 2023

Description

Due to a limitation where explained here.

When the secrets and parameter values are rotated or changed they are not automatically updated in your App Runner service. Redeploy your App Runner service as App Runner only pulls secrets and parameters during deployment.

We have a use case for manually starting the app runner deployment when an environment variable using aws secret manager/ssm parameter store is updated.

We would like a new resource aws_apprunner_start_deployment to start deployment and have it depend on changes in ssm paramter store / secret manager values

We are currently working around this issue by using the aws cli command: aws apprunner start-deployment

https://docs.aws.amazon.com/cli/latest/reference/apprunner/start-deployment.html

Affected Resource(s) and/or Data Source(s)

aws_apprunner_start_deployment

Potential Terraform Configuration

resource "aws_apprunner_start_deployment" "example" {
  service_arn = aws_apprunner_service.example.arn
}

References

https://docs.aws.amazon.com/cli/latest/reference/apprunner/start-deployment.html

Would you like to implement a fix?

None

@emoshaya emoshaya added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/apprunner Issues and PRs that pertain to the apprunner service. label Dec 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2023
@bschaatsbergen
Copy link
Member

Hi @emoshaya, thanks for taking the time to raise this issue! 👏🏼 I'll happily pick this up.

@bschaatsbergen bschaatsbergen self-assigned this Dec 10, 2023
@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer. label Dec 10, 2023
@bschaatsbergen
Copy link
Member

I am configuring the resource to wait until the deployment operation reaches the 'succeeded' status before deeming the creation process successful.

@emoshaya
Copy link
Author

@bschaatsbergen any update on this feature?

@bschaatsbergen
Copy link
Member

@bschaatsbergen any update on this feature?

Thanks for reaching out @emoshaya, I'm rewriting this resource in the coming days to adhere to the new standard of using the Terraform Provider Plugin Framework, shortly after that I would guess this gets merged. I'll keep you updated.

@bschaatsbergen
Copy link
Member

@emoshaya quick update from my side: the resource implementation is done, I just need to check why the test is failing.

@emoshaya
Copy link
Author

That's awesome! thank you for your time and effort on this.. greatly appreciated!

@github-actions github-actions bot added this to the v5.39.0 milestone Feb 23, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apprunner Issues and PRs that pertain to the apprunner service.
Projects
None yet
2 participants