Wait for import to complete during dynamodb table creation

[hsiam261]

Description

Terraform offers a way to create a dynamodb and initialize it with data from an s3 prefix.
This is done using the import_table option. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dynamodb_table#import_table

However, the provider doesn't validate if the import actually succeeded.
Even when the import fails, the table creation shows to be successful.

This PR resolves the issue by waiting for dynamodb import to become COMPLETE before moving on and if it fails, will throw an exception.

Relations

Closes #34847

References

• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dynamodb_table#import_table

Output from Acceptance Testing

Tried running make testacc TESTS=dynamo
It ran for a while with no bugs, and then wsl crashed :(

Other Tests

Applied the plan from the config mentioned in #34847 and it failed with an error (expected behavior)

Config File:

resource "aws_dynamodb_table" "siam-test-table" {
  name                        = "siam-test-table"
  billing_mode                = "PAY_PER_REQUEST"
  hash_key                    = "key"
  read_capacity               = 0
  write_capacity              = 0
  stream_enabled              = false
  tags_all                    = {}
  deletion_protection_enabled = false

  attribute {
    name = "key"
    type = "S"
  }


  import_table {
    input_compression_type = "GZIP"
    input_format           = "DYNAMODB_JSON"
    s3_bucket_source {
      bucket       = "<BUCKET WITH ONE FILE NOT OF THE GZIP FORMAT>"
      bucket_owner = "<ACCOUNT NUMBER>"
      key_prefix   = ""
    }
  }
}

Console Log

terraform apply plan.out
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - hashicorp/aws in /home/hsiam261/go/bin
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with
│ published releases.
╵
aws_dynamodb_table.siam-test-table: Creating...
aws_dynamodb_table.siam-test-table: Still creating... [10s elapsed]
aws_dynamodb_table.siam-test-table: Still creating... [20s elapsed]
aws_dynamodb_table.siam-test-table: Still creating... [30s elapsed]
aws_dynamodb_table.siam-test-table: Still creating... [40s elapsed]
aws_dynamodb_table.siam-test-table: Still creating... [50s elapsed]
aws_dynamodb_table.siam-test-table: Still creating... [1m0s elapsed]
aws_dynamodb_table.siam-test-table: Still creating... [1m10s elapsed]
╷
│ Error: creating Amazon DynamoDB Table: ImportArn "arn:aws:dynamodb:us-east-1:XXXXXXXXXXXX:table/siam-test-table/import/01702410536894-304cc257" : unexpected state 'FAILED', wanted target 'COMPLETED'. last error: %!s(<nil>)
│ 
│   with aws_dynamodb_table.siam-test-table,
│   on main.tf line 1, in resource "aws_dynamodb_table" "siam-test-table":
│    1: resource "aws_dynamodb_table" "siam-test-table" {
│ 
╵

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS="-run=estAccDynamoDBTable_importTable\|estAccDynamoDBTable_basic\|estAccDynamoDBTable_disappears" PKG=dynamodb

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20  -run=estAccDynamoDBTable_importTable\|estAccDynamoDBTable_basic\|estAccDynamoDBTable_disappears -timeout 360m
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== RUN   TestAccDynamoDBTable_disappears
=== PAUSE TestAccDynamoDBTable_disappears
=== RUN   TestAccDynamoDBTable_importTable
=== PAUSE TestAccDynamoDBTable_importTable
=== CONT  TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_importTable
=== CONT  TestAccDynamoDBTable_disappears
--- PASS: TestAccDynamoDBTable_disappears (35.23s)
--- PASS: TestAccDynamoDBTable_basic (38.93s)
--- PASS: TestAccDynamoDBTable_importTable (165.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	169.036s

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.