-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zonal_config
argument to aws_codedeploy_deployment_config
#34850
Conversation
Community NoteVoting for Prioritization
For Submitters
|
a0fe62f
to
3878bab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDeployDeploymentConfig_' PKG=deploy ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployDeploymentConfig_ -timeout 360m
2024/10/23 16:22:16 Initializing Terraform AWS Provider...
=== RUN TestAccDeployDeploymentConfig_basic
=== PAUSE TestAccDeployDeploymentConfig_basic
=== RUN TestAccDeployDeploymentConfig_disappears
=== PAUSE TestAccDeployDeploymentConfig_disappears
=== RUN TestAccDeployDeploymentConfig_fleetPercent
=== PAUSE TestAccDeployDeploymentConfig_fleetPercent
=== RUN TestAccDeployDeploymentConfig_hostCount
=== PAUSE TestAccDeployDeploymentConfig_hostCount
=== RUN TestAccDeployDeploymentConfig_trafficCanary
=== PAUSE TestAccDeployDeploymentConfig_trafficCanary
=== RUN TestAccDeployDeploymentConfig_trafficLinear
=== PAUSE TestAccDeployDeploymentConfig_trafficLinear
=== RUN TestAccDeployDeploymentConfig_zonalConfig
=== PAUSE TestAccDeployDeploymentConfig_zonalConfig
=== CONT TestAccDeployDeploymentConfig_basic
=== CONT TestAccDeployDeploymentConfig_trafficCanary
--- PASS: TestAccDeployDeploymentConfig_basic (13.79s)
=== CONT TestAccDeployDeploymentConfig_fleetPercent
--- PASS: TestAccDeployDeploymentConfig_trafficCanary (21.59s)
=== CONT TestAccDeployDeploymentConfig_hostCount
--- PASS: TestAccDeployDeploymentConfig_fleetPercent (20.12s)
=== CONT TestAccDeployDeploymentConfig_zonalConfig
--- PASS: TestAccDeployDeploymentConfig_hostCount (20.57s)
=== CONT TestAccDeployDeploymentConfig_disappears
--- PASS: TestAccDeployDeploymentConfig_disappears (10.43s)
=== CONT TestAccDeployDeploymentConfig_trafficLinear
--- PASS: TestAccDeployDeploymentConfig_zonalConfig (19.94s)
--- PASS: TestAccDeployDeploymentConfig_trafficLinear (20.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 78.249s
% make testacc TESTARGS='-run=TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple' PKG=deploy ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/deploy/... -v -count 1 -parallel 2 -run=TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple -timeout 360m
2024/10/23 16:29:50 Initializing Terraform AWS Provider...
=== RUN TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple
=== CONT TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple (23.36s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/deploy 28.498s
% make golangci-lint PKG=deploy
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`.
make: golangci-lint Checks / 3 of 3.. |
@alexknez Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
aws_codedeploy_deployment_config
: Adds a new attributezonal_config
.Relations
Closes #34849.
Closes #31402.
Closes #34779.
Closes #29628.
References
API Reference
Announcement
CloudFormation Resource
Output from Acceptance Testing