Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zonal_config argument to aws_codedeploy_deployment_config #34850

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

alexknez
Copy link
Contributor

@alexknez alexknez commented Dec 11, 2023

Description

aws_codedeploy_deployment_config: Adds a new attribute zonal_config.

Relations

Closes #34849.
Closes #31402.
Closes #34779.
Closes #29628.

References

API Reference
Announcement
CloudFormation Resource

Output from Acceptance Testing

% make testacc TESTS=TestAccDeployDeploymentConfig_ PKG=deploy
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/deploy/... -v -count 1 -parallel 20 -run='TestAccDeployDeploymentConfig_'  -timeout 360m
=== RUN   TestAccDeployDeploymentConfig_basic
=== PAUSE TestAccDeployDeploymentConfig_basic
=== RUN   TestAccDeployDeploymentConfig_fleetPercent
=== PAUSE TestAccDeployDeploymentConfig_fleetPercent
=== RUN   TestAccDeployDeploymentConfig_hostCount
=== PAUSE TestAccDeployDeploymentConfig_hostCount
=== RUN   TestAccDeployDeploymentConfig_trafficCanary
=== PAUSE TestAccDeployDeploymentConfig_trafficCanary
=== RUN   TestAccDeployDeploymentConfig_trafficLinear
=== PAUSE TestAccDeployDeploymentConfig_trafficLinear
=== RUN   TestAccDeployDeploymentConfig_zonalConfig
=== PAUSE TestAccDeployDeploymentConfig_zonalConfig
=== CONT  TestAccDeployDeploymentConfig_basic
=== CONT  TestAccDeployDeploymentConfig_trafficCanary
=== CONT  TestAccDeployDeploymentConfig_hostCount
=== CONT  TestAccDeployDeploymentConfig_fleetPercent
=== CONT  TestAccDeployDeploymentConfig_trafficLinear
=== CONT  TestAccDeployDeploymentConfig_zonalConfig
--- PASS: TestAccDeployDeploymentConfig_basic (26.45s)
--- PASS: TestAccDeployDeploymentConfig_trafficCanary (38.20s)
--- PASS: TestAccDeployDeploymentConfig_fleetPercent (38.68s)
--- PASS: TestAccDeployDeploymentConfig_trafficLinear (39.23s)
--- PASS: TestAccDeployDeploymentConfig_hostCount (39.73s)
--- PASS: TestAccDeployDeploymentConfig_zonalConfig (39.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/deploy     43.038s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/deploy Issues and PRs that pertain to the deploy service. labels Dec 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2023
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
@ewbankkit ewbankkit self-assigned this Oct 23, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 23, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner October 23, 2024 20:31
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDeployDeploymentConfig_' PKG=deploy ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployDeploymentConfig_ -timeout 360m
2024/10/23 16:22:16 Initializing Terraform AWS Provider...
=== RUN   TestAccDeployDeploymentConfig_basic
=== PAUSE TestAccDeployDeploymentConfig_basic
=== RUN   TestAccDeployDeploymentConfig_disappears
=== PAUSE TestAccDeployDeploymentConfig_disappears
=== RUN   TestAccDeployDeploymentConfig_fleetPercent
=== PAUSE TestAccDeployDeploymentConfig_fleetPercent
=== RUN   TestAccDeployDeploymentConfig_hostCount
=== PAUSE TestAccDeployDeploymentConfig_hostCount
=== RUN   TestAccDeployDeploymentConfig_trafficCanary
=== PAUSE TestAccDeployDeploymentConfig_trafficCanary
=== RUN   TestAccDeployDeploymentConfig_trafficLinear
=== PAUSE TestAccDeployDeploymentConfig_trafficLinear
=== RUN   TestAccDeployDeploymentConfig_zonalConfig
=== PAUSE TestAccDeployDeploymentConfig_zonalConfig
=== CONT  TestAccDeployDeploymentConfig_basic
=== CONT  TestAccDeployDeploymentConfig_trafficCanary
--- PASS: TestAccDeployDeploymentConfig_basic (13.79s)
=== CONT  TestAccDeployDeploymentConfig_fleetPercent
--- PASS: TestAccDeployDeploymentConfig_trafficCanary (21.59s)
=== CONT  TestAccDeployDeploymentConfig_hostCount
--- PASS: TestAccDeployDeploymentConfig_fleetPercent (20.12s)
=== CONT  TestAccDeployDeploymentConfig_zonalConfig
--- PASS: TestAccDeployDeploymentConfig_hostCount (20.57s)
=== CONT  TestAccDeployDeploymentConfig_disappears
--- PASS: TestAccDeployDeploymentConfig_disappears (10.43s)
=== CONT  TestAccDeployDeploymentConfig_trafficLinear
--- PASS: TestAccDeployDeploymentConfig_zonalConfig (19.94s)
--- PASS: TestAccDeployDeploymentConfig_trafficLinear (20.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	78.249s
% make testacc TESTARGS='-run=TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple' PKG=deploy ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/deploy/... -v -count 1 -parallel 2  -run=TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple -timeout 360m
2024/10/23 16:29:50 Initializing Terraform AWS Provider...
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple (23.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	28.498s

@ewbankkit
Copy link
Contributor

% make golangci-lint PKG=deploy
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
make: golangci-lint Checks / 3 of 3..

@ewbankkit
Copy link
Contributor

@alexknez Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 46bd33c into hashicorp:main Oct 23, 2024
39 of 40 checks passed
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 23, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/deploy Issues and PRs that pertain to the deploy service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants