[Enhancement]: aws_networkfirewall_firewall needs to support a timeouts block

[patrickcasady]

Description

aws_networkfirewall_firewall needs to support a timeouts block

This cloud resource frequently takes a long time (more than 20 minutes) to destroy when it is loaded up with any rules. The default timeout of 20 minutes is too low/not realistic for AWS Network Firewall.

Affected Resource(s) and/or Data Source(s)

aws_networkfirewall_firewall

Potential Terraform Configuration

resource "aws_networkfirewall_firewall" "example" {
  name                = "example"
  firewall_policy_arn = aws_networkfirewall_firewall_policy.example.arn
  vpc_id              = aws_vpc.example.id
  subnet_mapping {
    subnet_id = aws_subnet.example.id
  }

  tags = {
    Tag1 = "Value1"
    Tag2 = "Value2"
  }

  timeouts {
     create = "30m"
     delete = "30m"
  }
}

References

16:53:59 TestBasic 2023-12-11T21:53:59Z logger.go:66: [31m│[0m [0m[1m[31mError: [0m[0m[1mwaiting for NetworkFirewall Firewall (arn:aws:network-firewall:us-east-1:882292917843:firewall/aws-firewall-vpc-test) delete: timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 20m0s)[0m

CDK Deployment
✨ Total time: 363.95s (6 min 4 sec)
CDK Destroy
✨ Total time: 1292s (21 min 32 sec)

Not just terraform, Network Firewall is a slow resource to destroy

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[Kiyo510]

Hello, @AdamTylerLynch.
May I work on this issue?
This is my first time contributing to Terraform, but I think I can implement it in about 10 days.

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.