-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to forcibly delete EventBridge Rules #34905
Add an option to forcibly delete EventBridge Rules #34905
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @case-k-git 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hello @justinretzolk Thank you for label update. Could you please check this PR when you have time? |
Hello @ewbankkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
make testacc TESTARGS='-run=TestAccEventsRule_' PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/events/... -v -count 1 -parallel 20 -run=TestAccEventsRule_ -timeout 360m
rule_test.go:701: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
--- PASS: TestAccEventsRule_patternJSONEncoder (26.41s)
--- PASS: TestAccEventsRule_namePrefix (32.74s)
--- PASS: TestAccEventsRule_eventBusARN (34.35s)
--- PASS: TestAccEventsRule_Name_generated (34.55s)
--- PASS: TestAccEventsRule_scheduleAndPattern (34.88s)
--- PASS: TestAccEventsRule_role (41.73s)
--- PASS: TestAccEventsRule_description (48.13s)
--- PASS: TestAccEventsRule_pattern (48.96s)
--- PASS: TestAccEventsRule_state (51.05s)
--- PASS: TestAccEventsRule_migrateV0_Equivalent (0.00s)
--- PASS: TestAccEventsRule_migrateV0_Equivalent/disabled (52.88s)
--- PASS: TestAccEventsRule_migrateV0_Equivalent/enabled (54.85s)
--- PASS: TestAccEventsRule_migrateV0 (0.00s)
--- PASS: TestAccEventsRule_migrateV0/disabled (52.24s)
--- PASS: TestAccEventsRule_migrateV0/basic (55.88s)
--- PASS: TestAccEventsRule_migrateV0/enabled (57.16s)
--- PASS: TestAccEventsRule_tags (58.34s)
--- PASS: TestAccEventsRule_basic (58.41s)
--- PASS: TestAccEventsRule_eventBusName (59.17s)
--- PASS: TestAccEventsRule_isEnabled (60.99s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 66.943s
@case-k-git thank you for the contribution! 🎉 |
This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add force delete option to Event Bridge Rule
Relations
Closes #34906
References
Currently can not delete event bridge rule if target exist. API support force delete option so I add the force option
https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_DeleteRule.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_event_rule
Output from Acceptance Testing