-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neptune - support new storage type #34985
Neptune - support new storage type #34985
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @sagitsofan 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@sagitsofan - is there a reason this got closed? |
By mistake, reopened |
…er_parameter_group_name' to 'default.neptune1.3'.
# Conflicts: # internal/service/neptune/consts.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccNeptuneCluster_storageType\|TestAccNeptuneCluster_basic' PKG=neptune
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20 -run=TestAccNeptuneCluster_storageType\|TestAccNeptuneCluster_basic -timeout 360m
=== RUN TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN TestAccNeptuneCluster_storageType
=== PAUSE TestAccNeptuneCluster_storageType
=== CONT TestAccNeptuneCluster_basic
=== CONT TestAccNeptuneCluster_storageType
--- PASS: TestAccNeptuneCluster_basic (143.44s)
--- PASS: TestAccNeptuneCluster_storageType (187.21s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 193.226s
% make testacc TESTARGS='-run=TestAccNeptuneClusterInstance_basic' PKG=neptune
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20 -run=TestAccNeptuneClusterInstance_basic -timeout 360m
=== RUN TestAccNeptuneClusterInstance_basic
=== PAUSE TestAccNeptuneClusterInstance_basic
=== CONT TestAccNeptuneClusterInstance_basic
--- PASS: TestAccNeptuneClusterInstance_basic (1667.39s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 1673.347s
@sagitsofan Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adding support for storage type in Neptune cluster and instance
Relations
Closes #34984
References
Output from Acceptance Testing