Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: SageMaker Studio now supports local mode and Docker #35115

Closed
deepakbshetty opened this issue Jan 2, 2024 · 8 comments · Fixed by #35416
Closed

[Enhancement]: SageMaker Studio now supports local mode and Docker #35115

deepakbshetty opened this issue Jan 2, 2024 · 8 comments · Fixed by #35416
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@deepakbshetty
Copy link
Contributor

deepakbshetty commented Jan 2, 2024

Description

Studio users can now run SageMaker processing, training, inference and batch transform jobs locally on their Studio IDE instance. Users can also build and test SageMaker compatible Docker images locally in Studio IDEs. link

Usage guide - Link

@DrFaust92

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_domain

Potential Terraform Configuration

resource "aws_sagemaker_domain" "example" {
  domain_name = "example"
  auth_mode   = "IAM"
  vpc_id      = aws_vpc.example.id
  subnet_ids  = [aws_subnet.example.id]

  default_user_settings {
    execution_role  = aws_iam_role.example.arn
    studio_web_portal = "ENABLED"
    kernel_gateway_app_settings {
      custom_image {
        app_image_config_name = aws_sagemaker_app_image_config.example.app_image_config_name
        image_name            = aws_sagemaker_image_version.example.image_name
      }
    }
  }

    domain_settings {
      execution_role_identity_config = "USER_PROFILE_NAME|DISABLED"
      docker_settings {
        enable_docker_access      = "ENABLED|DISABLED"
        vpc_only_trusted_accounts = ["123456789012","111111111111"]
      }
    }  
}

References

Code Reference: https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/sagemaker/domain.go#L868

API Reference:
https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateDomain.html
https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_UpdateDomain.html

EnableDockerAccess
Indicates whether the domain can access Docker.
Type: String
Valid Values: ENABLED | DISABLED

VpcOnlyTrustedAccounts
The list of AWS accounts that are trusted when the domain is created in VPC-only mode.
Type: Array of strings
Length Constraints: Fixed length of 12.
Pattern: ^\d+$

Would you like to implement a fix?

No

@deepakbshetty deepakbshetty added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sagemaker Issues and PRs that pertain to the sagemaker service. label Jan 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 2, 2024
@deepakbshetty deepakbshetty changed the title [Enhancement]: Sagemaker studio local mode and docker support [Enhancement]: SageMaker Studio now supports local mode and Docker Jan 2, 2024
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2024
@DrFaust92 DrFaust92 self-assigned this Jan 3, 2024
@DrFaust92
Copy link
Collaborator

Hi, ill check this out. currently working on another sagemaker studio PR so should be fine to do within this context

@deepakbshetty
Copy link
Contributor Author

Hi @DrFaust92 👋 , Wondering if you had a chance to look at this. Appreciate you are busy with other priorities.

Thanks in advance,
Deepak

@rileyhun
Copy link

@deepakbshetty Any progress on this?

@deepakbshetty
Copy link
Contributor Author

Hi @rileyhun, PR pending with provider maintainers.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.67.0 milestone Sep 12, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
3 participants