Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_federation attribute #35154

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Add with_federation attribute #35154

merged 4 commits into from
Jan 31, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Jan 5, 2024

Description

Add with_federation attribute to aws_lakeformation_resource

Relations

Relates #33455

References

Output from Acceptance Testing

> make testacc TESTS=TestAccLakeFormationResource_ PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormationResource_'  -timeout 360m
=== RUN   TestAccLakeFormationResource_basic
=== PAUSE TestAccLakeFormationResource_basic
=== RUN   TestAccLakeFormationResource_disappears
=== PAUSE TestAccLakeFormationResource_disappears
=== RUN   TestAccLakeFormationResource_serviceLinkedRole
=== PAUSE TestAccLakeFormationResource_serviceLinkedRole
=== RUN   TestAccLakeFormationResource_updateRoleToRole
=== PAUSE TestAccLakeFormationResource_updateRoleToRole
=== RUN   TestAccLakeFormationResource_updateSLRToRole
=== PAUSE TestAccLakeFormationResource_updateSLRToRole
=== CONT  TestAccLakeFormationResource_basic
=== CONT  TestAccLakeFormationResource_updateRoleToRole
=== CONT  TestAccLakeFormationResource_serviceLinkedRole
=== CONT  TestAccLakeFormationResource_disappears
=== CONT  TestAccLakeFormationResource_updateSLRToRole
=== NAME  TestAccLakeFormationResource_serviceLinkedRole
    acctest.go:1117: skipping tests; missing IAM service-linked role /aws-service-role/lakeformation.amazonaws.com. Please create the role and retry
--- SKIP: TestAccLakeFormationResource_serviceLinkedRole (0.60s)
=== NAME  TestAccLakeFormationResource_updateSLRToRole
    acctest.go:1117: skipping tests; missing IAM service-linked role /aws-service-role/lakeformation.amazonaws.com. Please create the role and retry
--- SKIP: TestAccLakeFormationResource_updateSLRToRole (0.60s)
--- PASS: TestAccLakeFormationResource_basic (15.36s)
--- PASS: TestAccLakeFormationResource_disappears (15.94s)
--- PASS: TestAccLakeFormationResource_updateRoleToRole (27.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      33.745s

...

Copy link

github-actions bot commented Jan 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XS Managed by automation to categorize the size of a PR. labels Jan 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 5, 2024
@nam054 nam054 changed the title Add with_federation attribute [WIP] Add with_federation attribute Jan 5, 2024
Sharon Nam added 3 commits January 5, 2024 11:15
@nam054 nam054 changed the title [WIP] Add with_federation attribute Add with_federation attribute Jan 31, 2024
@nam054 nam054 merged commit a096f1e into main Jan 31, 2024
46 checks passed
@nam054 nam054 deleted the f-lakef-add-attr branch January 31, 2024 21:08
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 31, 2024
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant