-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: aws_synthetics_canary generate correct timeout_in_seconds if not set in run_config #35177
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @SebastianSlaby 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
```console % make testacc PKG=synthetics TESTS=TestAccSyntheticsCanary_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.0 test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_' -timeout 360m --- PASS: TestAccSyntheticsCanary_tags (88.14s) --- PASS: TestAccSyntheticsCanary_runtimeVersion (133.21s) --- PASS: TestAccSyntheticsCanary_run (168.45s) --- PASS: TestAccSyntheticsCanary_artifactEncryption (181.53s) --- PASS: TestAccSyntheticsCanary_startCanary (195.63s) --- PASS: TestAccSyntheticsCanary_runTracing (220.42s) --- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (236.81s) --- PASS: TestAccSyntheticsCanary_disappears (239.22s) --- PASS: TestAccSyntheticsCanary_s3 (523.47s) --- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (573.71s) --- PASS: TestAccSyntheticsCanary_basic (579.43s) --- PASS: TestAccSyntheticsCanary_rate (644.30s) --- PASS: TestAccSyntheticsCanary_vpc (2152.74s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 2158.743s ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=synthetics TESTS=TestAccSyntheticsCanary_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_' -timeout 360m
--- PASS: TestAccSyntheticsCanary_tags (88.14s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (133.21s)
--- PASS: TestAccSyntheticsCanary_run (168.45s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (181.53s)
--- PASS: TestAccSyntheticsCanary_startCanary (195.63s)
--- PASS: TestAccSyntheticsCanary_runTracing (220.42s)
--- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (236.81s)
--- PASS: TestAccSyntheticsCanary_disappears (239.22s)
--- PASS: TestAccSyntheticsCanary_s3 (523.47s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (573.71s)
--- PASS: TestAccSyntheticsCanary_basic (579.43s)
--- PASS: TestAccSyntheticsCanary_rate (644.30s)
--- PASS: TestAccSyntheticsCanary_vpc (2152.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 2158.743s
Thanks for your contribution, @SebastianSlaby! 👍 |
This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Currently, if
run_config
is set but the value oftimeout_in_seconds
is not, it will default to 840. This causes issues when the rate is set to anything below 14 minutes, as the timeout can not be higher than the frequency of the synthetic canary.This PR changes the behavior. so the value is computed by the AWS SDK based on the schedule.
relevant AWS SDK type
Relations
Closes #35176
References
Output from Acceptance Testing