-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set role_arn
data type to String in aws_iot_ca_certificate
#35234
fix: Set role_arn
data type to String in aws_iot_ca_certificate
#35234
Conversation
Community NoteVoting for Prioritization
For Submitters
|
7fec982
to
c5afa1b
Compare
role_arn
data type to String in aws_iot_ca_certificate
bd86249
to
46df850
Compare
46df850
to
b530e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIoTCACertificate_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTCACertificate_ -timeout 360m
=== RUN TestAccIoTCACertificate_basic
=== PAUSE TestAccIoTCACertificate_basic
=== RUN TestAccIoTCACertificate_disappears
=== PAUSE TestAccIoTCACertificate_disappears
=== RUN TestAccIoTCACertificate_tags
=== PAUSE TestAccIoTCACertificate_tags
=== RUN TestAccIoTCACertificate_defaultMode
=== PAUSE TestAccIoTCACertificate_defaultMode
=== RUN TestAccIoTCACertificate_registrationConfig
=== PAUSE TestAccIoTCACertificate_registrationConfig
=== CONT TestAccIoTCACertificate_basic
=== CONT TestAccIoTCACertificate_defaultMode
--- PASS: TestAccIoTCACertificate_basic (16.21s)
=== CONT TestAccIoTCACertificate_registrationConfig
--- PASS: TestAccIoTCACertificate_defaultMode (34.35s)
=== CONT TestAccIoTCACertificate_tags
--- PASS: TestAccIoTCACertificate_registrationConfig (30.33s)
=== CONT TestAccIoTCACertificate_disappears
--- PASS: TestAccIoTCACertificate_disappears (17.34s)
--- PASS: TestAccIoTCACertificate_tags (41.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 81.790s
@acwwat Thanks for the contribution 🎉 👏. |
Thanks for the update, good to see that there is a way to handle the IAM eventual consistency at the source :) |
This functionality has been released in v5.32.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to fix the data type of the
role_arn
attribute (change from Bool to String) for theaws_iot_ca_certificate
resource, so that it can actually be set.Relations
Closes #35079
References
Sample provisioning template was copied from Template example for just-in-time provisioning (JITP) in the AWS documentation.
Output from Acceptance Testing
Note:
TestAccIoTCACertificate_registrationConfig
is the new test case.