Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration block to aws_accessanalyzer_analyzer resource #35310

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Add configuration block to aws_accessanalyzer_analyzer resource #35310

merged 6 commits into from
Jan 24, 2024

Conversation

DanielRieske
Copy link
Contributor

Description

This PR adds the configuration argument to the aws_accessanalyzer_analyzer resource.
This argument contains information about the configuration of an unused access analyzer for an AWS organization or account.

Relations

Closes #35205

References

Output from Acceptance Testing

make testacc TESTS=TestAccAccessAnalyzer_serial/Analyzer/configuration PKG=accessanalyzer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20 -run='TestAccAccessAnalyzer_serial/Analyzer/configuration'  -timeout 360m
=== RUN   TestAccAccessAnalyzer_serial
=== PAUSE TestAccAccessAnalyzer_serial
=== CONT  TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/configuration
--- PASS: TestAccAccessAnalyzer_serial (18.84s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (18.84s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/configuration (18.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer     21.313s
make testacc TESTS=TestAccAccessAnalyzer_serial PKG=accessanalyzer 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20 -run='TestAccAccessAnalyzer_serial'  -timeout 360m
=== RUN   TestAccAccessAnalyzer_serial
=== PAUSE TestAccAccessAnalyzer_serial
=== CONT  TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Type_Organization
    acctest.go:982: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/basic
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/configuration
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/disappears
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/basic
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/disappears
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/update_filters
--- PASS: TestAccAccessAnalyzer_serial (163.71s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (91.58s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/Type_Organization (1.95s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (17.86s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/configuration (17.56s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (15.15s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags (39.06s)
    --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule (72.12s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/basic (18.23s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/disappears (15.91s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/update_filters (37.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer     166.182s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. labels Jan 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 15, 2024
@DanielRieske DanielRieske changed the title Add configuration argument to aws_accessanalyzer_analyzer resource Add configuration block to aws_accessanalyzer_analyzer resource Jan 15, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 16, 2024
ewbankkit
ewbankkit approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAccessAnalyzer_serial/Analyzer' PKG=accessanalyzer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20  -run=TestAccAccessAnalyzer_serial/Analyzer -timeout 360m
=== RUN   TestAccAccessAnalyzer_serial
=== PAUSE TestAccAccessAnalyzer_serial
=== CONT  TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/basic
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/configuration
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/disappears
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Type_Organization
    acctest.go:988: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- PASS: TestAccAccessAnalyzer_serial (89.30s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (89.30s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (18.36s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/configuration (17.13s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (14.75s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags (38.75s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/Type_Organization (0.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	99.749s
% make testacc TESTARGS='-run=TestAccAccessAnalyzer_serial/Analyzer/Type_Organization' PKG=accessanalyzer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20  -run=TestAccAccessAnalyzer_serial/Analyzer/Type_Organization -timeout 360m
=== RUN   TestAccAccessAnalyzer_serial
=== PAUSE TestAccAccessAnalyzer_serial
=== CONT  TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Type_Organization
--- PASS: TestAccAccessAnalyzer_serial (33.72s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (33.72s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/Type_Organization (33.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	44.559s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c5a285c into hashicorp:main Jan 24, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 24, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.34.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support new configuration attribute for aws_accessanalyzer_analyzer
3 participants
@DanielRieske @ewbankkit @justinretzolk