Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_m2_environment: Add Mainframe Modernization Environment resource #35311

Closed

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jan 15, 2024

Description

Add resource for managing AWS Mainframe Modernization environments.

Relations

Depends on #35309.
Closes #35379.

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/m2/... -v -count 1 -parallel 20 -run='TestAccM2Environment_'  -timeout 360m
=== RUN   TestAccM2Environment_basic
=== PAUSE TestAccM2Environment_basic
=== RUN   TestAccM2Environment_full
=== PAUSE TestAccM2Environment_full
=== RUN   TestAccM2Environment_update
=== PAUSE TestAccM2Environment_update
=== RUN   TestAccM2Environment_highAvailability
=== PAUSE TestAccM2Environment_highAvailability
=== RUN   TestAccM2Environment_efs
=== PAUSE TestAccM2Environment_efs
=== RUN   TestAccM2Environment_fsx
=== PAUSE TestAccM2Environment_fsx
=== RUN   TestAccM2Environment_disappears
=== PAUSE TestAccM2Environment_disappears
=== RUN   TestAccM2Environment_tags
=== PAUSE TestAccM2Environment_tags
=== CONT  TestAccM2Environment_basic
=== CONT  TestAccM2Environment_efs
=== CONT  TestAccM2Environment_update
=== CONT  TestAccM2Environment_highAvailability
=== CONT  TestAccM2Environment_full
=== CONT  TestAccM2Environment_disappears
=== CONT  TestAccM2Environment_tags
=== CONT  TestAccM2Environment_fsx
--- PASS: TestAccM2Environment_disappears (368.57s)
--- PASS: TestAccM2Environment_basic (423.01s)
--- PASS: TestAccM2Environment_highAvailability (433.89s)
--- PASS: TestAccM2Environment_full (462.32s)
--- PASS: TestAccM2Environment_efs (473.90s)
--- PASS: TestAccM2Environment_update (818.10s)
--- PASS: TestAccM2Environment_fsx (1144.78s)
--- PASS: TestAccM2Environment_tags (1319.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/m2 1324.493s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code labels Jan 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 15, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@drewtul drewtul changed the title resource/aws_m2_environment: Add Mainframe Modernization resource resource/aws_m2_environment: Add Mainframe Modernization Environment resource Jan 15, 2024
@github-actions github-actions bot removed sweeper Pertains to changes to or issues with the sweeper. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. github_actions Pull requests that update Github_actions code labels Jan 17, 2024
drewtul and others added 3 commits February 6, 2024 10:28
@breathingdust breathingdust added the partner Contribution from a partner. label Feb 20, 2024
@ewbankkit ewbankkit self-assigned this Mar 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 21, 2024
@meetreks
Copy link
Contributor

Thanks Kit, really helpful.

@drewtul drewtul deleted the f-mainframe-environment-resource branch March 27, 2024 21:01
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/m2 Issues and PRs that pertain to the m2 service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: f-aws_m2_environment
5 participants