r/aws_fsx_openzfs_file_system: Add skip_final_backup argument

[brinnjoyce]

Description

Add skip_final_backup argument to aws_fsx_openzfs_file_system to match aws_fsx_windows_file_system.
This allows skipping creating a final backup when deleting an aws_fsx_openzfs_file_system resource - defaults to the current behaviour of creating a backup.

Relations

Closes #35319

References

https://docs.aws.amazon.com/cli/latest/reference/fsx/delete-file-system.html#options
https://github.com/aws/aws-sdk-go/blob/main/service/fsx/api.go#L13017

Output from Acceptance Testing

% make testacc TESTS=TestAccFSxOpenZFSFileSystem PKG=fsx ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 4 -run='TestAccFSxOpenZFSFileSystem'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_basic
=== PAUSE TestAccFSxOpenZFSFileSystem_basic
=== RUN   TestAccFSxOpenZFSFileSystem_diskIops
=== PAUSE TestAccFSxOpenZFSFileSystem_diskIops
=== RUN   TestAccFSxOpenZFSFileSystem_disappears
=== PAUSE TestAccFSxOpenZFSFileSystem_disappears
=== RUN   TestAccFSxOpenZFSFileSystem_rootVolume
=== PAUSE TestAccFSxOpenZFSFileSystem_rootVolume
=== RUN   TestAccFSxOpenZFSFileSystem_securityGroupIDs
=== PAUSE TestAccFSxOpenZFSFileSystem_securityGroupIDs
=== RUN   TestAccFSxOpenZFSFileSystem_tags
=== PAUSE TestAccFSxOpenZFSFileSystem_tags
=== RUN   TestAccFSxOpenZFSFileSystem_copyTags
=== PAUSE TestAccFSxOpenZFSFileSystem_copyTags
=== RUN   TestAccFSxOpenZFSFileSystem_throughput
=== PAUSE TestAccFSxOpenZFSFileSystem_throughput
=== RUN   TestAccFSxOpenZFSFileSystem_storageType
=== PAUSE TestAccFSxOpenZFSFileSystem_storageType
=== RUN   TestAccFSxOpenZFSFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxOpenZFSFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxOpenZFSFileSystem_kmsKeyID
=== PAUSE TestAccFSxOpenZFSFileSystem_kmsKeyID
=== RUN   TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccFSxOpenZFSFileSystem_throughputCapacity
=== PAUSE TestAccFSxOpenZFSFileSystem_throughputCapacity
=== RUN   TestAccFSxOpenZFSFileSystem_storageCapacity
=== PAUSE TestAccFSxOpenZFSFileSystem_storageCapacity
=== RUN   TestAccFSxOpenZFSFileSystem_deploymentType
=== PAUSE TestAccFSxOpenZFSFileSystem_deploymentType
=== RUN   TestAccFSxOpenZFSFileSystem_multiAZ
=== PAUSE TestAccFSxOpenZFSFileSystem_multiAZ
=== RUN   TestAccFSxOpenZFSFileSystem_routeTableIDs
=== PAUSE TestAccFSxOpenZFSFileSystem_routeTableIDs
=== CONT  TestAccFSxOpenZFSFileSystem_basic
=== CONT  TestAccFSxOpenZFSFileSystem_weeklyMaintenanceStartTime
=== CONT  TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccFSxOpenZFSFileSystem_storageCapacity
--- PASS: TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime (470.50s)
=== CONT  TestAccFSxOpenZFSFileSystem_routeTableIDs
--- PASS: TestAccFSxOpenZFSFileSystem_weeklyMaintenanceStartTime (470.51s)
=== CONT  TestAccFSxOpenZFSFileSystem_throughputCapacity
--- PASS: TestAccFSxOpenZFSFileSystem_basic (493.65s)
=== CONT  TestAccFSxOpenZFSFileSystem_multiAZ
--- PASS: TestAccFSxOpenZFSFileSystem_storageCapacity (549.97s)
=== CONT  TestAccFSxOpenZFSFileSystem_tags
--- PASS: TestAccFSxOpenZFSFileSystem_tags (486.26s)
=== CONT  TestAccFSxOpenZFSFileSystem_deploymentType
--- PASS: TestAccFSxOpenZFSFileSystem_multiAZ (895.83s)
=== CONT  TestAccFSxOpenZFSFileSystem_storageType
--- PASS: TestAccFSxOpenZFSFileSystem_routeTableIDs (1003.06s)
=== CONT  TestAccFSxOpenZFSFileSystem_throughput
--- PASS: TestAccFSxOpenZFSFileSystem_throughputCapacity (1023.15s)
=== CONT  TestAccFSxOpenZFSFileSystem_kmsKeyID
--- PASS: TestAccFSxOpenZFSFileSystem_storageType (426.69s)
=== CONT  TestAccFSxOpenZFSFileSystem_copyTags
--- PASS: TestAccFSxOpenZFSFileSystem_kmsKeyID (447.17s)
=== CONT  TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxOpenZFSFileSystem_deploymentType (982.49s)
=== CONT  TestAccFSxOpenZFSFileSystem_rootVolume
--- PASS: TestAccFSxOpenZFSFileSystem_copyTags (458.76s)
=== CONT  TestAccFSxOpenZFSFileSystem_securityGroupIDs
--- PASS: TestAccFSxOpenZFSFileSystem_throughput (1065.26s)
=== CONT  TestAccFSxOpenZFSFileSystem_disappears
--- PASS: TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays (663.05s)
=== CONT  TestAccFSxOpenZFSFileSystem_diskIops
--- PASS: TestAccFSxOpenZFSFileSystem_disappears (433.59s)
--- PASS: TestAccFSxOpenZFSFileSystem_diskIops (550.24s)
--- PASS: TestAccFSxOpenZFSFileSystem_securityGroupIDs (904.25s)
--- PASS: TestAccFSxOpenZFSFileSystem_rootVolume (1218.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        3237.013s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @vegaman 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFSxBackup_openzfsBasic\|TestAccFSxOpenZFSVolume_basic\|TestAccFSxOpenZFSFileSystem_basic\|TestAccFSxOpenZFSFileSystem_throughputCapacity' PKG=fsx ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2  -run=TestAccFSxBackup_openzfsBasic\|TestAccFSxOpenZFSVolume_basic\|TestAccFSxOpenZFSFileSystem_basic\|TestAccFSxOpenZFSFileSystem_throughputCapacity -timeout 360m
=== RUN   TestAccFSxBackup_openzfsBasic
=== PAUSE TestAccFSxBackup_openzfsBasic
=== RUN   TestAccFSxOpenZFSFileSystem_basic
=== PAUSE TestAccFSxOpenZFSFileSystem_basic
=== RUN   TestAccFSxOpenZFSFileSystem_throughputCapacity
=== PAUSE TestAccFSxOpenZFSFileSystem_throughputCapacity
=== RUN   TestAccFSxOpenZFSVolume_basic
=== PAUSE TestAccFSxOpenZFSVolume_basic
=== CONT  TestAccFSxBackup_openzfsBasic
=== CONT  TestAccFSxOpenZFSFileSystem_throughputCapacity
--- PASS: TestAccFSxBackup_openzfsBasic (613.15s)
=== CONT  TestAccFSxOpenZFSVolume_basic
--- PASS: TestAccFSxOpenZFSFileSystem_throughputCapacity (1066.95s)
=== CONT  TestAccFSxOpenZFSFileSystem_basic
--- PASS: TestAccFSxOpenZFSVolume_basic (570.28s)
--- PASS: TestAccFSxOpenZFSFileSystem_basic (585.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1663.463s

[ewbankkit]

@brinnjoyce Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.