Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_mwaa_environment does not allow to chose Endpoint management creation #35339

Closed
renaudhager opened this issue Jan 17, 2024 · 5 comments · Fixed by #35961
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service.
Milestone

Comments

@renaudhager
Copy link

Terraform Core Version

1.2.0

AWS Provider Version

5.32.1

Affected Resource(s)

aws_mwaa_environment

Expected Behavior

The GO AWS SDK allow to set wether or not we want AWS to manage the VPC endpoint required for MWAA (EndpointManagement) so we expect to be able to do the same using Terraform.

Actual Behavior

Terraform does not support this field in the resource aws_mwaa_environment.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_mwaa_environment" "airflow_env" {
  dag_s3_path        = "s3://<REDACTED>-mwaa/dags/"
  execution_role_arn = aws_iam_role.mwaa_execution_role.arn
  name               = "<REDACTED>-dev-airflow-test-env"
  
  environment_class  = "mw1.small"
  max_workers        = 10
  min_workers        = 1
 
  network_configuration {
    security_group_ids = [aws_security_group.mwaa_security_group.id]
    subnet_ids         = ["subnet-081<REDACTED>", "subnet-01819<REDACTED>"]
  }
 
  source_bucket_arn = "arn:aws-cn:s3:::<REDACTED>-dev-mwaa"
 
  logging_configuration {
    dag_processing_logs {
      enabled   = true
      log_level = "DEBUG"
    }
 
    scheduler_logs {
      enabled   = true
      log_level = "INFO"
    }
  }
}

Steps to Reproduce

N/A

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@renaudhager renaudhager added the bug Addresses a defect in current functionality. label Jan 17, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/mwaa Issues and PRs that pertain to the mwaa service. label Jan 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 17, 2024
@justinretzolk
Copy link
Member

Hey @renaudhager 👋 Thank you for taking the time to raise this! We consider requests for additional functionality for existing resources to be a feature request, rather than a bug. With that in mind, I'll update the issue so that whoever looks into this knows what to expect coming in.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2024
@justinretzolk justinretzolk changed the title [Bug]: aws_mwaa_environment does not allow to chose Endpoint management creation [Enhancement]: aws_mwaa_environment does not allow to chose Endpoint management creation Jan 17, 2024
@renaudhager
Copy link
Author

Hey @renaudhager 👋 Thank you for taking the time to raise this! We consider requests for additional functionality for existing resources to be a feature request, rather than a bug. With that in mind, I'll update the issue so that whoever looks into this knows what to expect coming in.

Hi @justinretzolk,

Sure no worries.

Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants