Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Prometheus scraper role ARN #35453

Merged

Conversation

bonclay7
Copy link
Contributor

@bonclay7 bonclay7 commented Jan 23, 2024

Description

Prometheus scraper exposes a role ARN specific to the resource, and can be used for multiple purposes including automating scraper authentication in EKS.

Relations

Closes #35322

Output from Acceptance Testing

% make testacc TESTS=TestAccAMPScraper_basic PKG=amp
==> Checking that code complies with gofmt requirements...
go install
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 20 -run='TestAccAMPScraper_basic'  -timeout 360m
=== RUN   TestAccAMPScraper_basic
=== PAUSE TestAccAMPScraper_basic
=== CONT  TestAccAMPScraper_basic
--- PASS: TestAccAMPScraper_basic (2499.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	2506.015s

@bonclay7 bonclay7 marked this pull request as draft January 23, 2024 19:29
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/amp Issues and PRs that pertain to the amp service. labels Jan 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 23, 2024
@bonclay7 bonclay7 marked this pull request as ready for review January 23, 2024 20:15
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 23, 2024
@bonclay7
Copy link
Contributor Author

Forgot the role arn description in the doc. Will push a commit asap

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAMPScraper_basic' PKG=amp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 20  -run=TestAccAMPScraper_basic -timeout 360m
=== RUN   TestAccAMPScraper_basic
=== PAUSE TestAccAMPScraper_basic
=== CONT  TestAccAMPScraper_basic
--- PASS: TestAccAMPScraper_basic (2124.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	2139.762s

@ewbankkit
Copy link
Contributor

@bonclay7 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 387fe4b into hashicorp:main Jan 24, 2024
30 checks passed
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 24, 2024
@ewbankkit ewbankkit mentioned this pull request Jan 24, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/amp Issues and PRs that pertain to the amp service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_prometheus_scraper export "roleArn" attribute
3 participants