feat: add self managed active directory settings to aws_db_instance

[Ziziann]

Description

Adding support of self-managed active directory for aws_db_instance for MSSQL. That's an enhancement for the current configuration which is already supporting AWS managed active directory.

This is my first PR here, so please provide me some guidance if something else will be necessary to complete this pull request.

Adding:

• new attributes:
  • domain_auth_secret_arn
  • domain_dns_ips
  • domain_fqdn
  • domain_ou
• new outputs:
  • domain_auth_secret_arn
  • domain_dns_ips
  • domain_fqdn
  • domain_ou

The documentation also has been updated.

Relations

Closes #32641

References

• GO SDK docs: https://pkg.go.dev/github.com/aws/aws-sdk-go@v1.49.24/service/rds#CreateDBInstanceInput.DomainDnsIps
• AWS CLI docs: https://docs.aws.amazon.com/cli/latest/reference/rds/create-db-instance.html
• AWS docs: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_SQLServer_SelfManagedActiveDirectory.html

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSInstance_MSSQL_self* PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_MSSQL_self*'  -timeout 360m
=== RUN   TestAccRDSInstance_MSSQL_selfManagedDomain
=== PAUSE TestAccRDSInstance_MSSQL_selfManagedDomain
=== RUN   TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore
=== PAUSE TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomain
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore (2348.73s)
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomain (2423.37s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @Ziziann 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSInstance_basic\|TestAccRDSInstance_MSSQL_domain\|TestAccRDSInstance_MSSQL_selfManagedDomain' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_basic\|TestAccRDSInstance_MSSQL_domain\|TestAccRDSInstance_MSSQL_selfManagedDomain -timeout 720m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_MSSQL_domain
=== PAUSE TestAccRDSInstance_MSSQL_domain
=== RUN   TestAccRDSInstance_MSSQL_domainSnapshotRestore
=== PAUSE TestAccRDSInstance_MSSQL_domainSnapshotRestore
=== RUN   TestAccRDSInstance_MSSQL_selfManagedDomain
=== PAUSE TestAccRDSInstance_MSSQL_selfManagedDomain
=== RUN   TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore
=== PAUSE TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomain
--- PASS: TestAccRDSInstance_basic (512.12s)
=== CONT  TestAccRDSInstance_MSSQL_domainSnapshotRestore
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomain (2211.57s)
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore
--- PASS: TestAccRDSInstance_MSSQL_domainSnapshotRestore (3581.40s)
=== CONT  TestAccRDSInstance_MSSQL_domain
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore (2379.03s)
--- PASS: TestAccRDSInstance_MSSQL_domain (3524.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	7629.118s

[ewbankkit]

@Ziziann Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.