Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource slot_type #35555

Merged
merged 9 commits into from
Jan 31, 2024
Merged

New Resource slot_type #35555

merged 9 commits into from
Jan 31, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Jan 30, 2024

Description

New resource LexV2Models slot_type

Relations

Relates #21375

References

Output from Acceptance Testing

> make testacc TESTS=TestAccLexV2ModelsSlotType_ PKG=lexv2models
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsSlotType_'  -timeout 360m
=== RUN   TestAccLexV2ModelsSlotType_basic
=== PAUSE TestAccLexV2ModelsSlotType_basic
=== RUN   TestAccLexV2ModelsSlotType_disappears
=== PAUSE TestAccLexV2ModelsSlotType_disappears
=== CONT  TestAccLexV2ModelsSlotType_basic
=== CONT  TestAccLexV2ModelsSlotType_disappears
--- PASS: TestAccLexV2ModelsSlotType_disappears (37.69s)
--- PASS: TestAccLexV2ModelsSlotType_basic (56.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        62.650s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/lexv2models Issues and PRs that pertain to the lexv2models service. size/XL Managed by automation to categorize the size of a PR. labels Jan 30, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 30, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need:

  • Docs fixes
  • Changelog
    Other than that, LGTM 🎉
% make t T=TestAccLexV2ModelsSlotType_basic K=lexv2models
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsSlotType_basic'  -timeout 360m
=== RUN   TestAccLexV2ModelsSlotType_basic
=== PAUSE TestAccLexV2ModelsSlotType_basic
=== CONT  TestAccLexV2ModelsSlotType_basic
--- PASS: TestAccLexV2ModelsSlotType_basic (44.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models	46.207s

website/docs/r/lexv2models_slot_type.html.markdown Outdated Show resolved Hide resolved
website/docs/r/lexv2models_slot_type.html.markdown Outdated Show resolved Hide resolved
website/docs/r/lexv2models_slot_type.html.markdown Outdated Show resolved Hide resolved
website/docs/r/lexv2models_slot_type.html.markdown Outdated Show resolved Hide resolved
website/docs/r/lexv2models_slot_type.html.markdown Outdated Show resolved Hide resolved
website/docs/r/lexv2models_slot_type.html.markdown Outdated Show resolved Hide resolved
@nam054 nam054 marked this pull request as ready for review January 30, 2024 23:32
@nam054 nam054 merged commit 27e2738 into main Jan 31, 2024
44 checks passed
@nam054 nam054 deleted the f-resource-slottype branch January 31, 2024 00:19
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 31, 2024
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lexv2models Issues and PRs that pertain to the lexv2models service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants