Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_plan: Fix GovCloud InvalidParameterValueException: Invalid lifecycle. EBS Cold Tier is not yet supported #35560

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 30, 2024

Description

Fixes aws_backup_plan InvalidParameterValueException: Invalid lifecycle. EBS Cold Tier is not yet supported errors on resource Create in AWS GovCloud (US).

Relations

Closes #35512.
Relates #34994.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccBackupPlan_' PKG=backup ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupPlan_ -timeout 360m
=== RUN   TestAccBackupPlan_basic
=== PAUSE TestAccBackupPlan_basic
=== RUN   TestAccBackupPlan_withTags
=== PAUSE TestAccBackupPlan_withTags
=== RUN   TestAccBackupPlan_withRules
=== PAUSE TestAccBackupPlan_withRules
=== RUN   TestAccBackupPlan_withLifecycle
=== PAUSE TestAccBackupPlan_withLifecycle
=== RUN   TestAccBackupPlan_withRecoveryPointTags
=== PAUSE TestAccBackupPlan_withRecoveryPointTags
=== RUN   TestAccBackupPlan_RuleCopyAction_sameRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_sameRegion
=== RUN   TestAccBackupPlan_RuleCopyAction_noLifecycle
=== PAUSE TestAccBackupPlan_RuleCopyAction_noLifecycle
=== RUN   TestAccBackupPlan_RuleCopyAction_multiple
=== PAUSE TestAccBackupPlan_RuleCopyAction_multiple
=== RUN   TestAccBackupPlan_RuleCopyAction_crossRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_crossRegion
=== RUN   TestAccBackupPlan_advancedBackupSetting
=== PAUSE TestAccBackupPlan_advancedBackupSetting
=== RUN   TestAccBackupPlan_enableContinuousBackup
=== PAUSE TestAccBackupPlan_enableContinuousBackup
=== RUN   TestAccBackupPlan_disappears
=== PAUSE TestAccBackupPlan_disappears
=== CONT  TestAccBackupPlan_basic
=== CONT  TestAccBackupPlan_RuleCopyAction_noLifecycle
=== CONT  TestAccBackupPlan_advancedBackupSetting
--- PASS: TestAccBackupPlan_basic (25.66s)
=== CONT  TestAccBackupPlan_RuleCopyAction_crossRegion
--- PASS: TestAccBackupPlan_advancedBackupSetting (41.93s)
=== CONT  TestAccBackupPlan_disappears
--- PASS: TestAccBackupPlan_RuleCopyAction_noLifecycle (60.00s)
=== CONT  TestAccBackupPlan_enableContinuousBackup
--- PASS: TestAccBackupPlan_RuleCopyAction_crossRegion (38.43s)
=== CONT  TestAccBackupPlan_RuleCopyAction_multiple
--- PASS: TestAccBackupPlan_disappears (23.42s)
=== CONT  TestAccBackupPlan_withLifecycle
--- PASS: TestAccBackupPlan_enableContinuousBackup (23.41s)
=== CONT  TestAccBackupPlan_RuleCopyAction_sameRegion
--- PASS: TestAccBackupPlan_RuleCopyAction_multiple (25.02s)
=== CONT  TestAccBackupPlan_withRecoveryPointTags
--- PASS: TestAccBackupPlan_RuleCopyAction_sameRegion (62.54s)
=== CONT  TestAccBackupPlan_withRules
--- PASS: TestAccBackupPlan_withRecoveryPointTags (58.86s)
=== CONT  TestAccBackupPlan_withTags
--- PASS: TestAccBackupPlan_withLifecycle (89.91s)
--- PASS: TestAccBackupPlan_withRules (50.50s)
--- PASS: TestAccBackupPlan_withTags (49.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	210.143s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/backup Issues and PRs that pertain to the backup service. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 30, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 30, 2024
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Jan 30, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 30, 2024
@ewbankkit ewbankkit merged commit 97203c4 into main Jan 30, 2024
76 checks passed
@ewbankkit ewbankkit deleted the r-aws_backup_plan-OptInToArchiveForSupportedResources-GovCloud branch January 30, 2024 13:56
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 30, 2024
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Feb 2, 2024
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partition/aws-us-gov Pertains to the aws-us-gov partition. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/backup Issues and PRs that pertain to the backup service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_backup_plan unable to apply in GovCloud
2 participants