-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B fix ssm patching manager to set computed value as new #35606
B fix ssm patching manager to set computed value as new #35606
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSSMPatchBaseline_' PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run=TestAccSSMPatchBaseline_ -timeout 360m
=== RUN TestAccSSMPatchBaseline_basic
=== PAUSE TestAccSSMPatchBaseline_basic
=== RUN TestAccSSMPatchBaseline_tags
=== PAUSE TestAccSSMPatchBaseline_tags
=== RUN TestAccSSMPatchBaseline_disappears
=== PAUSE TestAccSSMPatchBaseline_disappears
=== RUN TestAccSSMPatchBaseline_operatingSystem
=== PAUSE TestAccSSMPatchBaseline_operatingSystem
=== RUN TestAccSSMPatchBaseline_approveUntilDateParam
=== PAUSE TestAccSSMPatchBaseline_approveUntilDateParam
=== RUN TestAccSSMPatchBaseline_sources
=== PAUSE TestAccSSMPatchBaseline_sources
=== RUN TestAccSSMPatchBaseline_approvedPatchesNonSec
=== PAUSE TestAccSSMPatchBaseline_approvedPatchesNonSec
=== RUN TestAccSSMPatchBaseline_rejectPatchesAction
=== PAUSE TestAccSSMPatchBaseline_rejectPatchesAction
=== CONT TestAccSSMPatchBaseline_basic
=== CONT TestAccSSMPatchBaseline_rejectPatchesAction
--- PASS: TestAccSSMPatchBaseline_rejectPatchesAction (23.97s)
=== CONT TestAccSSMPatchBaseline_approveUntilDateParam
--- PASS: TestAccSSMPatchBaseline_basic (38.16s)
=== CONT TestAccSSMPatchBaseline_approvedPatchesNonSec
--- PASS: TestAccSSMPatchBaseline_approveUntilDateParam (35.37s)
=== CONT TestAccSSMPatchBaseline_sources
--- PASS: TestAccSSMPatchBaseline_approvedPatchesNonSec (21.44s)
=== CONT TestAccSSMPatchBaseline_disappears
--- PASS: TestAccSSMPatchBaseline_disappears (19.97s)
=== CONT TestAccSSMPatchBaseline_operatingSystem
--- PASS: TestAccSSMPatchBaseline_sources (38.83s)
=== CONT TestAccSSMPatchBaseline_tags
--- PASS: TestAccSSMPatchBaseline_operatingSystem (42.31s)
--- PASS: TestAccSSMPatchBaseline_tags (54.18s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 163.551s
% make testacc TESTARGS='-run=TestAccSSM_serial' PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run=TestAccSSM_serial -timeout 360m
=== RUN TestAccSSM_serial
=== PAUSE TestAccSSM_serial
=== CONT TestAccSSM_serial
=== RUN TestAccSSM_serial/DefaultPatchBaseline
=== RUN TestAccSSM_serial/DefaultPatchBaseline/multiRegion
=== RUN TestAccSSM_serial/DefaultPatchBaseline/basic
=== RUN TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN
=== RUN TestAccSSM_serial/DefaultPatchBaseline/deleteDefault
=== RUN TestAccSSM_serial/DefaultPatchBaseline/update
=== RUN TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem
=== RUN TestAccSSM_serial/DefaultPatchBaseline/disappears
=== RUN TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem
=== RUN TestAccSSM_serial/DefaultPatchBaseline/systemDefault
=== RUN TestAccSSM_serial/PatchBaseline
=== RUN TestAccSSM_serial/PatchBaseline/deleteDefault
--- PASS: TestAccSSM_serial (256.66s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline (236.53s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/multiRegion (38.18s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/basic (25.54s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN (26.13s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/deleteDefault (24.68s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/update (45.85s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem (10.56s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/disappears (18.95s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem (23.48s)
--- PASS: TestAccSSM_serial/DefaultPatchBaseline/systemDefault (23.18s)
--- PASS: TestAccSSM_serial/PatchBaseline (20.13s)
--- PASS: TestAccSSM_serial/PatchBaseline/deleteDefault (20.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 268.898s
@stromp Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
#33565 introduced a bug where the json value was not recalculated when the configuration changed. This PR address this. And adds a test to prevent a regression next time
Relations
Relates #33565
Output from Acceptance Testing