Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Db2 CloudWatch log exports for aws_db_instance #35626

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Feb 3, 2024

Description

This PR adds support for the Db2-specific values, diag.log and notify.log for the enabled_cloudwatch_logs_exports attribute of the aws-db-instance resource.

Relations

Closes #35611

References

Referenced CreateDBInstance API doc for the Db2 CloudWatch log export values/

Output from Acceptance Testing

$ export RDS_DB2_CUSTOMER_ID=111111

$ export RDS_DB2_SITE_ID=1111111

$ make testacc TESTS=TestAccRDSInstance_EnabledCloudWatchLogsExports_db2 PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_EnabledCloudWatchLogsExports_db2'  -timeout 360m
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_db2
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_db2
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_db2
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_db2 (1311.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1311.654s

$

Copy link

github-actions bot commented Feb 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels Feb 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2024
@acwwat acwwat force-pushed the f-aws_db_instance-cw_log_exports_db_values branch from 18ee6c5 to 6a34a29 Compare February 3, 2024 07:37
@acwwat acwwat changed the title [WIP] feat: Support Db2 CloudWatch log exports for aws_db_instance feat: Support Db2 CloudWatch log exports for aws_db_instance Feb 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 5, 2024
@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 98ef8a6 into hashicorp:main Feb 5, 2024
31 checks passed
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 5, 2024
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_db_instance-cw_log_exports_db_values branch February 10, 2024 05:10
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support DB2 cloudwatch log exports
2 participants