Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds: Improve version/instance data sources #35698

Merged
merged 23 commits into from
Feb 9, 2024
Merged

rds: Improve version/instance data sources #35698

merged 23 commits into from
Feb 9, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 7, 2024 •
edited
Loading

Description

Relations

Closes #13718

References

Output from Acceptance Testing

% make t T=TestAccRDSOrderableInstanceDataSource_ K=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSOrderableInstanceDataSource_'  -timeout 360m
=== RUN   TestAccRDSOrderableInstanceDataSource_basic
=== PAUSE TestAccRDSOrderableInstanceDataSource_basic
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClass
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClass
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== RUN   TestAccRDSOrderableInstanceDataSource_latestVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_latestVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsClusters
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsClusters
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== RUN   TestAccRDSOrderableInstanceDataSource_supportedEngineModes
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportedEngineModes
=== RUN   TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIops
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIops
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== CONT  TestAccRDSOrderableInstanceDataSource_basic
=== CONT  TestAccRDSOrderableInstanceDataSource_supportedEngineModes
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIops
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredVersion
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClass
=== CONT  TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
=== CONT  TestAccRDSOrderableInstanceDataSource_latestVersion
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsClusters
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases (84.28s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportedEngineModes (130.97s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring (153.47s)
--- PASS: TestAccRDSOrderableInstanceDataSource_basic (172.56s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClass (175.19s)
--- PASS: TestAccRDSOrderableInstanceDataSource_latestVersion (182.57s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication (207.58s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion (337.05s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption (370.72s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling (372.59s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsMultiAZ (373.53s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredVersion (398.28s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsClusters (409.61s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes (494.69s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIops (537.60s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication (574.38s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights (578.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	580.672s
% make t T=TestAccRDSEngineVersionDataSource_ K=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSEngineVersionDataSource_'  -timeout 360m
=== RUN   TestAccRDSEngineVersionDataSource_basic
=== PAUSE TestAccRDSEngineVersionDataSource_basic
=== RUN   TestAccRDSEngineVersionDataSource_upgradeTargets
=== PAUSE TestAccRDSEngineVersionDataSource_upgradeTargets
=== RUN   TestAccRDSEngineVersionDataSource_preferred
=== PAUSE TestAccRDSEngineVersionDataSource_preferred
=== RUN   TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== PAUSE TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== RUN   TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== PAUSE TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== RUN   TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== PAUSE TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== RUN   TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== PAUSE TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== RUN   TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== PAUSE TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== RUN   TestAccRDSEngineVersionDataSource_includeAll
=== PAUSE TestAccRDSEngineVersionDataSource_includeAll
=== RUN   TestAccRDSEngineVersionDataSource_filter
=== PAUSE TestAccRDSEngineVersionDataSource_filter
=== RUN   TestAccRDSEngineVersionDataSource_latest
=== PAUSE TestAccRDSEngineVersionDataSource_latest
=== CONT  TestAccRDSEngineVersionDataSource_basic
=== CONT  TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== CONT  TestAccRDSEngineVersionDataSource_latest
=== CONT  TestAccRDSEngineVersionDataSource_upgradeTargets
=== CONT  TestAccRDSEngineVersionDataSource_includeAll
=== CONT  TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== CONT  TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== CONT  TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== CONT  TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== CONT  TestAccRDSEngineVersionDataSource_preferred
=== CONT  TestAccRDSEngineVersionDataSource_filter
--- PASS: TestAccRDSEngineVersionDataSource_defaultOnlyImplicit (21.65s)
--- PASS: TestAccRDSEngineVersionDataSource_includeAll (22.42s)
--- PASS: TestAccRDSEngineVersionDataSource_defaultOnlyExplicit (22.43s)
--- PASS: TestAccRDSEngineVersionDataSource_upgradeTargets (22.52s)
--- PASS: TestAccRDSEngineVersionDataSource_basic (22.55s)
--- PASS: TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion (22.67s)
--- PASS: TestAccRDSEngineVersionDataSource_filter (32.11s)
--- PASS: TestAccRDSEngineVersionDataSource_preferred (32.12s)
--- PASS: TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets (32.18s)
--- PASS: TestAccRDSEngineVersionDataSource_preferredMajorTargets (34.41s)
--- PASS: TestAccRDSEngineVersionDataSource_latest (48.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	50.544s
% make t T=TestAccRDSCluster_ K=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_'  -timeout 360m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== RUN   TestAccRDSCluster_identifierGenerated
=== PAUSE TestAccRDSCluster_identifierGenerated
=== RUN   TestAccRDSCluster_identifierPrefix
=== PAUSE TestAccRDSCluster_identifierPrefix
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== RUN   TestAccRDSCluster_allowMajorVersionUpgrade
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgrade
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== RUN   TestAccRDSCluster_onlyMajorVersion
=== PAUSE TestAccRDSCluster_onlyMajorVersion
=== RUN   TestAccRDSCluster_minorVersion
=== PAUSE TestAccRDSCluster_minorVersion
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_storageTypeIo1
=== PAUSE TestAccRDSCluster_storageTypeIo1
=== RUN   TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== PAUSE TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== RUN   TestAccRDSCluster_allocatedStorage
=== PAUSE TestAccRDSCluster_allocatedStorage
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== RUN   TestAccRDSCluster_dbClusterInstanceClass
=== PAUSE TestAccRDSCluster_dbClusterInstanceClass
=== RUN   TestAccRDSCluster_backtrackWindow
=== PAUSE TestAccRDSCluster_backtrackWindow
=== RUN   TestAccRDSCluster_dbSubnetGroupName
=== PAUSE TestAccRDSCluster_dbSubnetGroupName
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== RUN   TestAccRDSCluster_takeFinalSnapshot
=== PAUSE TestAccRDSCluster_takeFinalSnapshot
=== RUN   TestAccRDSCluster_missingUserNameCausesError
=== PAUSE TestAccRDSCluster_missingUserNameCausesError
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSCluster_updateIAMRoles
=== PAUSE TestAccRDSCluster_updateIAMRoles
=== RUN   TestAccRDSCluster_kmsKey
=== PAUSE TestAccRDSCluster_kmsKey
=== RUN   TestAccRDSCluster_networkType
=== PAUSE TestAccRDSCluster_networkType
=== RUN   TestAccRDSCluster_encrypted
=== PAUSE TestAccRDSCluster_encrypted
=== RUN   TestAccRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot
=== RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_backupsUpdate
=== PAUSE TestAccRDSCluster_backupsUpdate
=== RUN   TestAccRDSCluster_iamAuth
=== PAUSE TestAccRDSCluster_iamAuth
=== RUN   TestAccRDSCluster_deletionProtection
=== PAUSE TestAccRDSCluster_deletionProtection
=== RUN   TestAccRDSCluster_engineMode
=== PAUSE TestAccRDSCluster_engineMode
=== RUN   TestAccRDSCluster_engineVersion
=== PAUSE TestAccRDSCluster_engineVersion
=== RUN   TestAccRDSCluster_engineVersionWithPrimaryInstance
=== PAUSE TestAccRDSCluster_engineVersionWithPrimaryInstance
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managed
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managed
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== RUN   TestAccRDSCluster_port
=== PAUSE TestAccRDSCluster_port
=== RUN   TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== RUN   TestAccRDSCluster_serverlessV2ScalingConfiguration
=== PAUSE TestAccRDSCluster_serverlessV2ScalingConfiguration
=== RUN   TestAccRDSCluster_Scaling_defaultMinCapacity
=== PAUSE TestAccRDSCluster_Scaling_defaultMinCapacity
=== RUN   TestAccRDSCluster_snapshotIdentifier
=== PAUSE TestAccRDSCluster_snapshotIdentifier
=== RUN   TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless
    cluster_test.go:1985: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== RUN   TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== RUN   TestAccRDSCluster_enableHTTPEndpoint
=== PAUSE TestAccRDSCluster_enableHTTPEndpoint
=== RUN   TestAccRDSCluster_password
=== PAUSE TestAccRDSCluster_password
=== RUN   TestAccRDSCluster_NoDeleteAutomatedBackups
=== PAUSE TestAccRDSCluster_NoDeleteAutomatedBackups
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_deletionProtection
=== CONT  TestAccRDSCluster_iops
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== CONT  TestAccRDSCluster_onlyMajorVersion
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== CONT  TestAccRDSCluster_NoDeleteAutomatedBackups
=== CONT  TestAccRDSCluster_password
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
=== CONT  TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== CONT  TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== CONT  TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== CONT  TestAccRDSCluster_SnapshotIdentifier_tags
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_basic (212.86s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_deletionProtection (265.25s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (323.29s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_password (327.91s)
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (398.48s)
=== CONT  TestAccRDSCluster_Scaling_defaultMinCapacity
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (400.01s)
=== CONT  TestAccRDSCluster_serverlessV2ScalingConfiguration
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (400.04s)
=== CONT  TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (400.28s)
=== CONT  TestAccRDSCluster_port
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (401.27s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (403.79s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (418.69s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (435.88s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
--- PASS: TestAccRDSCluster_NoDeleteAutomatedBackups (477.89s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (489.72s)
=== CONT  TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (511.47s)
=== CONT  TestAccRDSCluster_engineVersion
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (162.23s)
=== CONT  TestAccRDSCluster_engineMode
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (351.04s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (169.08s)
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (165.40s)
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (150.35s)
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (130.61s)
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (210.45s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (359.37s)
=== CONT  TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
--- PASS: TestAccRDSCluster_port (232.17s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
--- PASS: TestAccRDSCluster_snapshotIdentifier (357.68s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (291.63s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_scaling (322.27s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
--- PASS: TestAccRDSCluster_identifierPrefix (159.81s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (409.89s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_tags (150.20s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (189.60s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (187.27s)
=== CONT  TestAccRDSCluster_iamAuth
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (242.66s)
=== CONT  TestAccRDSCluster_encrypted
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (232.15s)
=== CONT  TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (171.12s)
=== CONT  TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (170.06s)
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_engineMode (393.25s)
=== CONT  TestAccRDSCluster_identifierGenerated
--- PASS: TestAccRDSCluster_engineVersion (450.93s)
=== CONT  TestAccRDSCluster_backupsUpdate
--- PASS: TestAccRDSCluster_iamAuth (156.48s)
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (218.11s)
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_encrypted (146.11s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_kmsKey (149.99s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_disappears (163.51s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_identifierGenerated (183.66s)
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_missingUserNameCausesError (5.99s)
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_updateIAMRoles (296.54s)
=== CONT  TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_dbSubnetGroupName (247.73s)
=== CONT  TestAccRDSCluster_storageTypeIo1
--- PASS: TestAccRDSCluster_backupsUpdate (425.84s)
=== CONT  TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_networkType (550.98s)
=== CONT  TestAccRDSCluster_storageTypeAuroraReturnsBlank
--- PASS: TestAccRDSCluster_onlyMajorVersion (1412.77s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (477.48s)
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (479.88s)
=== CONT  TestAccRDSCluster_minorVersion
--- PASS: TestAccRDSCluster_pointInTimeRestore (389.95s)
--- PASS: TestAccRDSCluster_takeFinalSnapshot (364.93s)
--- PASS: TestAccRDSCluster_availabilityZones (159.02s)
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (167.63s)
--- PASS: TestAccRDSCluster_backtrackWindow (198.77s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (1227.50s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1593.67s)
--- PASS: TestAccRDSCluster_iops (2142.99s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (2261.22s)
--- PASS: TestAccRDSCluster_allocatedStorage (1711.27s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2324.60s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2410.30s)
--- PASS: TestAccRDSCluster_minorVersion (1370.73s)
--- PASS: TestAccRDSCluster_storageTypeIo1 (1738.58s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2496.74s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2917.67s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (3014.94s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (3206.54s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (3272.18s)
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (4071.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	5548.817s
% make t T=TestAccRDSOptionGroup_basicDestroyWithInstance K=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSOptionGroup_basicDestroyWithInstance'  -timeout 360m
=== RUN   TestAccRDSOptionGroup_basicDestroyWithInstance
=== PAUSE TestAccRDSOptionGroup_basicDestroyWithInstance
=== CONT  TestAccRDSOptionGroup_basicDestroyWithInstance
--- PASS: TestAccRDSOptionGroup_basicDestroyWithInstance (478.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	480.305s
% make t T=TestAccRDSInstanceAutomatedBackupsReplication_ K=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceAutomatedBackupsReplication_'  -timeout 360m
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_basic
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_basic
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_basic
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_disappears
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_basic (1129.03s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod (1311.20s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_disappears (1395.87s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted (1433.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1435.924s

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels Feb 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 7, 2024
@ewbankkit
Copy link
Contributor

Possible future work -- Replace internal/verify/semver.go with github.com/YakDriver/go-version?

ewbankkit
ewbankkit approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@YakDriver YakDriver merged commit e41498b into main Feb 9, 2024
50 checks passed
@YakDriver YakDriver deleted the f-rds-test-improve branch February 9, 2024 03:10
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 9, 2024
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
Update CHANGELOG.md for #35698
8bf32cc
This was referenced Feb 9, 2024
Open
Open
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.37.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @ewbankkit