-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_redshiftserverless_workgroup: Add max_capacity argument #35720
r/aws_redshiftserverless_workgroup: Add max_capacity argument #35720
Conversation
Community NoteVoting for Prioritization
For Submitters
|
f182f31
to
3186468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @marcinbelczewski 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=redshiftserverless TESTS=TestAccRedshiftServerlessWorkgroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20 -run='TestAccRedshiftServerlessWorkgroup_' -timeout 360m
--- PASS: TestAccRedshiftServerlessWorkgroup_disappears (237.95s)
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (291.33s)
--- PASS: TestAccRedshiftServerlessWorkgroup_port (291.34s)
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (296.67s)
--- PASS: TestAccRedshiftServerlessWorkgroup_configParameters (302.82s)
--- PASS: TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible (434.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 441.178s
Thanks for your contribution, @marcinbelczewski! 👍 |
This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds max_capacity argument to aws_redshiftserverless_workgroup resource allowing for better control of workgroup scale-out hence costs.
Relations
Closes #35719
Closes #34440
References
Maximum capacity setting is described in AWS docs here
Output from Acceptance Testing
% make testacc TESTS=TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible PKG=redshiftserverless