Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ Network Monitor Monitor and Probe #35722

Merged
merged 21 commits into from
Jun 24, 2024

Conversation

juhala-aws
Copy link
Contributor

Description

This PR will create Amazon Cloudwatch Network Monitor service Monitor and Probe resources.

Relations

Closes #35342

References

API documentation: https://docs.aws.amazon.com/networkmonitor/latest/APIReference/Welcome.html
https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-cloudwatch-network-monitor-generally-available/
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/what-is-network-monitor.html

This is supported by the Go SDK: https://docs.aws.amazon.com/sdk-for-go/api/service/networkmonitor/

Output from Acceptance Testing

make testacc TESTS=TestAccNetworkMonitorMonitor PKG=networkmonitor
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmonitor/... -v -count 1 -parallel 20 -run='TestAccNetworkMonitorMonitor'  -timeout 360m
=== RUN   TestAccNetworkMonitorMonitor_basic
=== PAUSE TestAccNetworkMonitorMonitor_basic
=== RUN   TestAccNetworkMonitorMonitor_updates
=== PAUSE TestAccNetworkMonitorMonitor_updates
=== RUN   TestAccNetworkMonitorMonitor_disappears
=== PAUSE TestAccNetworkMonitorMonitor_disappears
=== CONT  TestAccNetworkMonitorMonitor_basic
=== CONT  TestAccNetworkMonitorMonitor_disappears
=== CONT  TestAccNetworkMonitorMonitor_updates
--- PASS: TestAccNetworkMonitorMonitor_disappears (29.79s)
--- PASS: TestAccNetworkMonitorMonitor_basic (30.80s)
--- PASS: TestAccNetworkMonitorMonitor_updates (42.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmonitor	50.013s

make testacc TESTS=TestAccNetworkMonitorProbe PKG=networkmonitor
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmonitor/... -v -count 1 -parallel 20 -run='TestAccNetworkMonitorProbe'  -timeout 360m
=== RUN   TestAccNetworkMonitorProbe_basic
=== PAUSE TestAccNetworkMonitorProbe_basic
=== RUN   TestAccNetworkMonitorProbe_updates
=== PAUSE TestAccNetworkMonitorProbe_updates
=== RUN   TestAccNetworkMonitorProbe_disappears
=== PAUSE TestAccNetworkMonitorProbe_disappears
=== CONT  TestAccNetworkMonitorProbe_basic
=== CONT  TestAccNetworkMonitorProbe_disappears
=== CONT  TestAccNetworkMonitorProbe_updates
--- PASS: TestAccNetworkMonitorProbe_basic (299.20s)
--- PASS: TestAccNetworkMonitorProbe_disappears (336.00s)
--- PASS: TestAccNetworkMonitorProbe_updates (364.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmonitor	372.174s

...

Copy link

github-actions bot commented Feb 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code labels Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Feb 8, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Feb 8, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner June 24, 2024 12:38
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkMonitorMonitor_' PKG=networkmonitor ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/networkmonitor/... -v -count 1 -parallel 2  -run=TestAccNetworkMonitorMonitor_ -timeout 360m
=== RUN   TestAccNetworkMonitorMonitor_basic
=== PAUSE TestAccNetworkMonitorMonitor_basic
=== RUN   TestAccNetworkMonitorMonitor_tags
=== PAUSE TestAccNetworkMonitorMonitor_tags
=== RUN   TestAccNetworkMonitorMonitor_disappears
=== PAUSE TestAccNetworkMonitorMonitor_disappears
=== CONT  TestAccNetworkMonitorMonitor_basic
=== CONT  TestAccNetworkMonitorMonitor_disappears
--- PASS: TestAccNetworkMonitorMonitor_disappears (12.64s)
=== CONT  TestAccNetworkMonitorMonitor_tags
--- PASS: TestAccNetworkMonitorMonitor_basic (23.23s)
--- PASS: TestAccNetworkMonitorMonitor_tags (30.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmonitor	47.385s
% make testacc TESTARGS='-run=TestAccNetworkMonitorProbe_' PKG=networkmonitor ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/networkmonitor/... -v -count 1 -parallel 2  -run=TestAccNetworkMonitorProbe_ -timeout 360m
=== RUN   TestAccNetworkMonitorProbe_basic
=== PAUSE TestAccNetworkMonitorProbe_basic
=== RUN   TestAccNetworkMonitorProbe_disappears
=== PAUSE TestAccNetworkMonitorProbe_disappears
=== RUN   TestAccNetworkMonitorProbe_tags
=== PAUSE TestAccNetworkMonitorProbe_tags
=== RUN   TestAccNetworkMonitorProbe_update
=== PAUSE TestAccNetworkMonitorProbe_update
=== CONT  TestAccNetworkMonitorProbe_basic
=== CONT  TestAccNetworkMonitorProbe_tags
--- PASS: TestAccNetworkMonitorProbe_tags (329.67s)
=== CONT  TestAccNetworkMonitorProbe_disappears
--- PASS: TestAccNetworkMonitorProbe_basic (339.02s)
=== CONT  TestAccNetworkMonitorProbe_update
--- PASS: TestAccNetworkMonitorProbe_disappears (323.48s)
--- PASS: TestAccNetworkMonitorProbe_update (439.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmonitor	783.038s

@ewbankkit
Copy link
Contributor

@juhala-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added new-resource Introduces a new resource. new-service Introduces a new service. labels Jun 24, 2024
@ewbankkit ewbankkit merged commit 17bac54 into hashicorp:main Jun 24, 2024
30 of 35 checks passed
@github-actions github-actions bot added this to the v5.56.0 milestone Jun 24, 2024
Copy link

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. new-service Introduces a new service. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Service]: Amazon Cloudwatch Network Monitor
3 participants