Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_resolver_rule: add protocols #35744

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Feb 9, 2024

Description

target_ip.protocol parameter added to select a protocol for multiprotocol endpoints.

Relations

Closes #35733

References

#35098

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ResolverRule_forward PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRule_forwardMultiProtocol'  -timeout 360m
=== RUN   TestAccRoute53ResolverRule_forward
=== PAUSE TestAccRoute53ResolverRule_forward
=== RUN   TestAccRoute53ResolverRule_forwardMultiProtocol
=== PAUSE TestAccRoute53ResolverRule_forwardMultiProtocol
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate
=== CONT  TestAccRoute53ResolverRule_forward
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate
=== CONT  TestAccRoute53ResolverRule_forwardMultiProtocol
--- PASS: TestAccRoute53ResolverRule_forward (305.13s)
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (320.71s)
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate (495.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    500.604s

Copy link

github-actions bot commented Feb 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Feb 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 9, 2024
@aristosvo aristosvo force-pushed the feat/r53-resolver-rule-protocol branch 3 times, most recently from 24094bd to fc86097 Compare February 9, 2024 19:59
@aristosvo aristosvo force-pushed the feat/r53-resolver-rule-protocol branch from fc86097 to 3dc2370 Compare February 9, 2024 20:05
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ResolverRule_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverRule_ -timeout 360m
=== RUN   TestAccRoute53ResolverRule_basic
=== PAUSE TestAccRoute53ResolverRule_basic
=== RUN   TestAccRoute53ResolverRule_disappears
=== PAUSE TestAccRoute53ResolverRule_disappears
=== RUN   TestAccRoute53ResolverRule_tags
=== PAUSE TestAccRoute53ResolverRule_tags
=== RUN   TestAccRoute53ResolverRule_justDotDomainName
=== PAUSE TestAccRoute53ResolverRule_justDotDomainName
=== RUN   TestAccRoute53ResolverRule_trailingDotDomainName
=== PAUSE TestAccRoute53ResolverRule_trailingDotDomainName
=== RUN   TestAccRoute53ResolverRule_updateName
=== PAUSE TestAccRoute53ResolverRule_updateName
=== RUN   TestAccRoute53ResolverRule_forward
=== PAUSE TestAccRoute53ResolverRule_forward
=== RUN   TestAccRoute53ResolverRule_forwardMultiProtocol
=== PAUSE TestAccRoute53ResolverRule_forwardMultiProtocol
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate
=== CONT  TestAccRoute53ResolverRule_basic
=== CONT  TestAccRoute53ResolverRule_updateName
--- PASS: TestAccRoute53ResolverRule_basic (22.56s)
=== CONT  TestAccRoute53ResolverRule_justDotDomainName
--- PASS: TestAccRoute53ResolverRule_updateName (35.91s)
=== CONT  TestAccRoute53ResolverRule_trailingDotDomainName
--- PASS: TestAccRoute53ResolverRule_justDotDomainName (19.87s)
=== CONT  TestAccRoute53ResolverRule_tags
--- PASS: TestAccRoute53ResolverRule_trailingDotDomainName (19.03s)
=== CONT  TestAccRoute53ResolverRule_disappears
--- PASS: TestAccRoute53ResolverRule_disappears (16.17s)
=== CONT  TestAccRoute53ResolverRule_forwardMultiProtocol
--- PASS: TestAccRoute53ResolverRule_tags (42.24s)
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (273.99s)
=== CONT  TestAccRoute53ResolverRule_forward
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate (438.26s)
--- PASS: TestAccRoute53ResolverRule_forward (273.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	628.441s

@ewbankkit ewbankkit merged commit 5f2cb01 into hashicorp:main Feb 13, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 13, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Specify protocol (Do53/DoH/...) for Route53 resolver rule
3 participants