d/aws_ec2_instance_type maximum_network_cards

[bryantbiggs]

Description

• Add attribute for maximum_network_cards to the aws_ec2_instance_type data source. This is used to show the max number of EFA devices that can be exposed on EFA supported instance types

Relations

References

Output from Acceptance Testing

make testacc TESTS="TestAccEC2InstanceTypeDataSource_" PKG=ec2                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypeDataSource_'  -timeout 360m
=== RUN   TestAccEC2InstanceTypeDataSource_basic
=== PAUSE TestAccEC2InstanceTypeDataSource_basic
=== RUN   TestAccEC2InstanceTypeDataSource_metal
=== PAUSE TestAccEC2InstanceTypeDataSource_metal
=== RUN   TestAccEC2InstanceTypeDataSource_gpu
=== PAUSE TestAccEC2InstanceTypeDataSource_gpu
=== RUN   TestAccEC2InstanceTypeDataSource_fpga
=== PAUSE TestAccEC2InstanceTypeDataSource_fpga
=== CONT  TestAccEC2InstanceTypeDataSource_basic
=== CONT  TestAccEC2InstanceTypeDataSource_gpu
=== CONT  TestAccEC2InstanceTypeDataSource_fpga
=== CONT  TestAccEC2InstanceTypeDataSource_metal
--- PASS: TestAccEC2InstanceTypeDataSource_gpu (21.63s)
--- PASS: TestAccEC2InstanceTypeDataSource_fpga (21.76s)
--- PASS: TestAccEC2InstanceTypeDataSource_metal (21.79s)
--- PASS: TestAccEC2InstanceTypeDataSource_basic (21.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        22.127s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[bryantbiggs]

@ewbankkit if this (small) one could go out in the next release 🙏🏽 😬

[jar-b]

LGTM 🎉

% make testacc PKG=ec2 TESTS=TestAccEC2InstanceTypeDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypeDataSource_'  -timeout 360m

--- PASS: TestAccEC2InstanceTypeDataSource_basic (9.00s)
--- PASS: TestAccEC2InstanceTypeDataSource_gpu (9.03s)
--- PASS: TestAccEC2InstanceTypeDataSource_metal (9.09s)
--- PASS: TestAccEC2InstanceTypeDataSource_fpga (9.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        16.493s

[jar-b]

Thanks for your contribution, @bryantbiggs! 👍

[github-actions]

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.