Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_redshiftserverless_custom_domain_association: implement new resource #35865

Conversation

marcinbelczewski
Copy link

Description

This PR implements aws_redshiftserverless_custom_domain_association to configure custom domain name for Amazon Redshift Serverless Workgroup.

Relations

Closes #35288

Output from Acceptance Testing

make testacc TESTS=TestAccRedshiftServerlessCustomDomainAssociation PKG=redshiftserverless

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/XL Managed by automation to categorize the size of a PR. labels Feb 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 16, 2024
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_custom_domain_association branch 6 times, most recently from 00a2093 to 6ce1289 Compare February 16, 2024 22:37
@marcinbelczewski marcinbelczewski marked this pull request as ready for review February 16, 2024 22:38
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_custom_domain_association branch 4 times, most recently from 785b0cf to 8ae5d51 Compare February 16, 2024 23:03
@marcinbelczewski marcinbelczewski marked this pull request as draft February 16, 2024 23:37
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_custom_domain_association branch from 8ae5d51 to 6bb1a4e Compare February 17, 2024 00:03
@marcinbelczewski marcinbelczewski marked this pull request as ready for review February 17, 2024 00:39
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 17, 2024
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_custom_domain_association branch 2 times, most recently from 7a8696f to 5034cbf Compare February 29, 2024 22:02
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_custom_domain_association branch from 5034cbf to ad342fe Compare February 29, 2024 22:16
@marcinbelczewski
Copy link
Author

Please let me know if I should do anything to get this merged?

Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACM_CERTIFICATE_ROOT_DOMAIN=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccRedshiftServerlessCustomDomainAssociation_' PKG=redshiftserverless ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshiftserverless/... -v -count 1 -parallel 2  -run=TestAccRedshiftServerlessCustomDomainAssociation_ -timeout 360m
=== RUN   TestAccRedshiftServerlessCustomDomainAssociation_basic
=== PAUSE TestAccRedshiftServerlessCustomDomainAssociation_basic
=== RUN   TestAccRedshiftServerlessCustomDomainAssociation_disappears
=== PAUSE TestAccRedshiftServerlessCustomDomainAssociation_disappears
=== CONT  TestAccRedshiftServerlessCustomDomainAssociation_basic
=== CONT  TestAccRedshiftServerlessCustomDomainAssociation_disappears
--- PASS: TestAccRedshiftServerlessCustomDomainAssociation_disappears (300.57s)
--- PASS: TestAccRedshiftServerlessCustomDomainAssociation_basic (314.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	325.167s

@ewbankkit
Copy link
Contributor

@marcinbelczewski Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f324545 into hashicorp:main Mar 25, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 25, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support to create/update/delete custom domain association for Amazon Redshift Serverless
3 participants