-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_redshiftserverless_custom_domain_association: implement new resource #35865
r/aws_redshiftserverless_custom_domain_association: implement new resource #35865
Conversation
Community NoteVoting for Prioritization
For Submitters
|
00a2093
to
6ce1289
Compare
785b0cf
to
8ae5d51
Compare
8ae5d51
to
6bb1a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7a8696f
to
5034cbf
Compare
5034cbf
to
ad342fe
Compare
Please let me know if I should do anything to get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACM_CERTIFICATE_ROOT_DOMAIN=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccRedshiftServerlessCustomDomainAssociation_' PKG=redshiftserverless ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshiftserverless/... -v -count 1 -parallel 2 -run=TestAccRedshiftServerlessCustomDomainAssociation_ -timeout 360m
=== RUN TestAccRedshiftServerlessCustomDomainAssociation_basic
=== PAUSE TestAccRedshiftServerlessCustomDomainAssociation_basic
=== RUN TestAccRedshiftServerlessCustomDomainAssociation_disappears
=== PAUSE TestAccRedshiftServerlessCustomDomainAssociation_disappears
=== CONT TestAccRedshiftServerlessCustomDomainAssociation_basic
=== CONT TestAccRedshiftServerlessCustomDomainAssociation_disappears
--- PASS: TestAccRedshiftServerlessCustomDomainAssociation_disappears (300.57s)
--- PASS: TestAccRedshiftServerlessCustomDomainAssociation_basic (314.19s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 325.167s
@marcinbelczewski Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR implements aws_redshiftserverless_custom_domain_association to configure custom domain name for Amazon Redshift Serverless Workgroup.
Relations
Closes #35288
Output from Acceptance Testing
make testacc TESTS=TestAccRedshiftServerlessCustomDomainAssociation PKG=redshiftserverless