Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ec2_instance/spot_instance_request: add configurable read timeout #35955

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

Relations

Closes #19313

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue\|TestAccEC2Instance_basic\|TestAccEC2Instance_GetPasswordData_falseToTrue\|TestAccEC2Instance_disappears\|TestAccEC2SpotInstanceRequest_basic\|TestAccEC2SpotInstanceRequest_getPasswordData' PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue\|TestAccEC2Instance_basic\|TestAccEC2Instance_GetPasswordData_falseToTrue\|TestAccEC2Instance_disappears\|TestAccEC2SpotInstanceRequest_basic\|TestAccEC2SpotInstanceRequest_getPasswordData -timeout 360m
--- PASS: TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue (143.07s)
--- PASS: TestAccEC2Instance_GetPasswordData_falseToTrue (153.60s)
--- PASS: TestAccEC2SpotInstanceRequest_getPasswordData (159.60s)
--- PASS: TestAccEC2Instance_basicWithSpot (299.26s)
--- PASS: TestAccEC2Instance_basic (299.62s)
--- PASS: TestAccEC2SpotInstanceRequest_basic (307.09s)
--- PASS: TestAccEC2Instance_disappears (353.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	360.974s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Feb 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 23, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 23, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue\|TestAccEC2Instance_basic\|TestAccEC2Instance_GetPasswordData_falseToTrue\|TestAccEC2Instance_disappears\|TestAccEC2SpotInstanceRequest_basic\|TestAccEC2SpotInstanceRequest_getPasswordData' PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue\|TestAccEC2Instance_basic\|TestAccEC2Instance_GetPasswordData_falseToTrue\|TestAccEC2Instance_disappears\|TestAccEC2SpotInstanceRequest_basic\|TestAccEC2SpotInstanceRequest_getPasswordData -timeout 360m
=== RUN   TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue
=== PAUSE TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_disappears
=== PAUSE TestAccEC2Instance_disappears
=== RUN   TestAccEC2Instance_GetPasswordData_falseToTrue
=== PAUSE TestAccEC2Instance_GetPasswordData_falseToTrue
=== RUN   TestAccEC2Instance_basicWithSpot
=== PAUSE TestAccEC2Instance_basicWithSpot
=== RUN   TestAccEC2SpotInstanceRequest_basic
=== PAUSE TestAccEC2SpotInstanceRequest_basic
=== RUN   TestAccEC2SpotInstanceRequest_getPasswordData
=== PAUSE TestAccEC2SpotInstanceRequest_getPasswordData
=== CONT  TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue
=== CONT  TestAccEC2Instance_basicWithSpot
=== CONT  TestAccEC2SpotInstanceRequest_getPasswordData
=== CONT  TestAccEC2SpotInstanceRequest_basic
=== CONT  TestAccEC2Instance_disappears
=== CONT  TestAccEC2Instance_GetPasswordData_falseToTrue
=== CONT  TestAccEC2Instance_basic
--- PASS: TestAccEC2SpotInstanceRequest_getPasswordData (139.14s)
--- PASS: TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue (174.03s)
--- PASS: TestAccEC2Instance_GetPasswordData_falseToTrue (183.34s)
--- PASS: TestAccEC2SpotInstanceRequest_basic (304.96s)
--- PASS: TestAccEC2Instance_disappears (312.71s)
--- PASS: TestAccEC2Instance_basic (316.80s)
--- PASS: TestAccEC2Instance_basicWithSpot (318.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        325.717s

@johnsonaj johnsonaj merged commit e2e6017 into main Feb 23, 2024
41 checks passed
@johnsonaj johnsonaj deleted the f-aws_ec2_instance_read_timeout branch February 23, 2024 19:40
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 23, 2024
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_password_data timeout at 15 minutes if AWS does not return password by then
2 participants