Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Updating aws_redshiftserverless_workgroup base and max capacities failures #36030

Closed
marcinbelczewski opened this issue Feb 29, 2024 · 3 comments · Fixed by #36032
Closed
Labels
bug Addresses a defect in current functionality. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service.
Milestone

Comments

@marcinbelczewski
Copy link

marcinbelczewski commented Feb 29, 2024

Terraform Core Version

1.7.4

AWS Provider Version

5.38.0

Affected Resource(s)

aws_redshiftserverless_workgroup

Expected Behavior

Updating base_capacity and max_capacity should succeed no matter what current and new values are as long those are within acceptable limits.

Actual Behavior

Since Amazon Redshift Serverless API only allows for updating Workgroups one attribute at a time, the ordering of updates of base_capacity and max_capacity on aws_redshiftserverless_workgroup matters. Currently, provider updates attributes in alphabetical order so base_capacity is update first and then max_capacity.
So, if for example current base_capacity is 128 and max_capacity is 256, and new update is attempted for base_capacity to 512 and max_capacity to 1024, the first update to base_capacity will fail as it's larger value than current max_capacity of 256. In this case, max_capacity should be updated first to 1024 and only after base_capacity to 512.

When lowering the values for base_capacity and max_capacity, the reverse order is often required to first lower base_capacity and only after lower max_capacity.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_redshiftserverless_namespace" "this" {
  namespace_name = "test"
}

resource "aws_redshiftserverless_workgroup" "this" {
  namespace_name = aws_redshiftserverless_namespace.this.namespace_name
  workgroup_name = "test"
  base_capacity  = 128
  max_capacity   = 256
}

Steps to Reproduce

Update the base_capacity to 512 and max_capacity to 1024 and apply. It will fail.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

Yes

@marcinbelczewski marcinbelczewski added the bug Addresses a defect in current functionality. label Feb 29, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. label Feb 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 29, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 29, 2024
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 29, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service.
Projects
None yet
2 participants