-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for io2 storage type in RDS resources #36252
Conversation
Community NoteVoting for Prioritization
For Submitters
|
bcd12a2
to
e317808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @relu 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSCluster_storageType\|TestAccRDSCluster_basic\|TestAccRDSInstance_SnapshotIdentifier_io\|TestAccRDSInstance_basic\|TestAccRDSInstance_Storage_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3 -run=TestAccRDSCluster_storageType\|TestAccRDSCluster_basic\|TestAccRDSInstance_SnapshotIdentifier_io\|TestAccRDSInstance_basic\|TestAccRDSInstance_Storage_ -timeout 360m
=== RUN TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN TestAccRDSCluster_storageTypeIo1
=== PAUSE TestAccRDSCluster_storageTypeIo1
=== RUN TestAccRDSCluster_storageTypeIo2
=== PAUSE TestAccRDSCluster_storageTypeIo2
=== RUN TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== PAUSE TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== RUN TestAccRDSCluster_storageTypeAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1
=== RUN TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== RUN TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== RUN TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN TestAccRDSInstance_Storage_maxAllocated
=== PAUSE TestAccRDSInstance_Storage_maxAllocated
=== RUN TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== RUN TestAccRDSInstance_SnapshotIdentifier_io2Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io2Storage
=== RUN TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== PAUSE TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== RUN TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
=== PAUSE TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
=== RUN TestAccRDSInstance_Storage_gp3MySQL
=== PAUSE TestAccRDSInstance_Storage_gp3MySQL
=== RUN TestAccRDSInstance_Storage_gp3Postgres
=== PAUSE TestAccRDSInstance_Storage_gp3Postgres
=== RUN TestAccRDSInstance_Storage_gp3SQLServer
=== PAUSE TestAccRDSInstance_Storage_gp3SQLServer
=== RUN TestAccRDSInstance_Storage_changeThroughput
=== PAUSE TestAccRDSInstance_Storage_changeThroughput
=== RUN TestAccRDSInstance_Storage_changeIOPSThroughput
=== PAUSE TestAccRDSInstance_Storage_changeIOPSThroughput
=== RUN TestAccRDSInstance_Storage_changeIOPS
=== PAUSE TestAccRDSInstance_Storage_changeIOPS
=== RUN TestAccRDSInstance_Storage_throughputSSE
=== PAUSE TestAccRDSInstance_Storage_throughputSSE
=== RUN TestAccRDSInstance_Storage_typePostgres
=== PAUSE TestAccRDSInstance_Storage_typePostgres
=== CONT TestAccRDSCluster_basic
=== CONT TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
=== CONT TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
--- PASS: TestAccRDSCluster_basic (134.16s)
=== CONT TestAccRDSCluster_storageTypeAuroraReturnsBlank
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (211.80s)
=== CONT TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (159.62s)
=== CONT TestAccRDSCluster_storageTypeAuroraIopt1
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (191.99s)
=== CONT TestAccRDSCluster_storageTypeIo2
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (128.66s)
=== CONT TestAccRDSCluster_storageTypeIo1
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io1 (703.31s)
=== CONT TestAccRDSInstance_SnapshotIdentifier_io1Storage
--- PASS: TestAccRDSCluster_storageTypeIo2 (1705.42s)
=== CONT TestAccRDSInstance_SnapshotIdentifier_io2Storage
--- PASS: TestAccRDSCluster_storageTypeIo1 (1744.52s)
=== CONT TestAccRDSInstance_Storage_changeThroughput
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io1Storage (1863.81s)
=== CONT TestAccRDSInstance_Storage_typePostgres
--- PASS: TestAccRDSInstance_Storage_changeThroughput (669.43s)
=== CONT TestAccRDSInstance_Storage_throughputSSE
--- PASS: TestAccRDSInstance_Storage_typePostgres (684.02s)
=== CONT TestAccRDSInstance_Storage_changeIOPS
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io2Storage (1543.31s)
=== CONT TestAccRDSInstance_Storage_changeIOPSThroughput
--- PASS: TestAccRDSInstance_Storage_throughputSSE (962.36s)
=== CONT TestAccRDSInstance_Storage_maxAllocated
--- PASS: TestAccRDSInstance_Storage_changeIOPS (700.85s)
=== CONT TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_Storage_changeIOPSThroughput (684.45s)
=== CONT TestAccRDSInstance_Storage_gp3Postgres
--- PASS: TestAccRDSInstance_basic (504.46s)
=== CONT TestAccRDSInstance_Storage_gp3SQLServer
--- PASS: TestAccRDSInstance_Storage_maxAllocated (786.48s)
=== CONT TestAccRDSInstance_Storage_gp3MySQL
--- PASS: TestAccRDSInstance_Storage_gp3Postgres (828.91s)
=== CONT TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
--- PASS: TestAccRDSInstance_Storage_gp3MySQL (778.96s)
--- PASS: TestAccRDSInstance_Storage_gp3SQLServer (1176.97s)
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io2 (661.27s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 5834.863s
@relu Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for
io2
storage type in RDS resources.Relations
Closes #36250
References
Output from Acceptance Testing