Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: CodePipeline - Manual Approval Timeout #36278

Closed
apples723 opened this issue Mar 8, 2024 · 4 comments · Fixed by #36316
Closed

[Enhancement]: CodePipeline - Manual Approval Timeout #36278

apples723 opened this issue Mar 8, 2024 · 4 comments · Fixed by #36316
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Milestone

Comments

@apples723
Copy link

apples723 commented Mar 8, 2024

Description

AWS has continually added new functionality to CodePipeline, recently adding support for a configurable timeout for manual approval actions. I am requesting new input from the action configuration block to set timeouts. This removes the need for a custom Lambda or solution to time out stale pipelines.

This functionality was released and added on February 15

Affected Resource(s) and/or Data Source(s)

  • aws_codepipeline

Potential Terraform Configuration

resource "aws_codepipeline" "codepipeline" {
  name     = "approve_pipeline"
  role_arn = aws_iam_role.pipeline.arn
  ...   
  stage {
    name = "Stage-AppoveChange"
    action {
      name      = "ApproveChange"
      category  = "Approval"
      owner     = "AWS"
      provider  = "Manual"
      version   = "1"
      run_order = 2
      timeout_in_minutes = 15 # new input
      configuration = {
        "CustomData"         = "Approval required for change:  # 
      {SourceVariables.CommitMessage}"
     }
    }
  }
   ...
}

References

  1. AWS CodePipeline Documentation - Timeout Qutoas
  2. AWS CodePipeline ActionDeclearation - timeoutInMinutes

Would you like to implement a fix?

None

@apples723 apples723 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/codepipeline Issues and PRs that pertain to the codepipeline service. label Mar 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 8, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 11, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.59.0 milestone Jul 17, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants