-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ec2_instance: allow adjusting ipv6_address_count without replacing the instance #36308
aws_ec2_instance: allow adjusting ipv6_address_count without replacing the instance #36308
Conversation
It looks like the ipv6 address list is strongly ordered in some ad-hoc tests, so this is likely to be reasonably sane in behavior
It runs, but it requires that the host subnet have IPv6 CIDRs assigned.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @hfinucane 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2Instance_IPv6\|TestAccEC2Instance_basic\|TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2Instance_IPv6\|TestAccEC2Instance_basic\|TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError -timeout 360m
=== RUN TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN TestAccEC2Instance_IPv6_supportAddressCount
=== PAUSE TestAccEC2Instance_IPv6_supportAddressCount
=== RUN TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
=== RUN TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
=== PAUSE TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
=== RUN TestAccEC2Instance_IPv6AddressCount
=== PAUSE TestAccEC2Instance_IPv6AddressCount
=== RUN TestAccEC2Instance_basicWithSpot
=== PAUSE TestAccEC2Instance_basicWithSpot
=== CONT TestAccEC2Instance_basic
=== CONT TestAccEC2Instance_basicWithSpot
=== CONT TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
--- PASS: TestAccEC2Instance_basic (121.12s)
=== CONT TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError (5.32s)
=== CONT TestAccEC2Instance_IPv6_supportAddressCount
--- PASS: TestAccEC2Instance_basicWithSpot (156.62s)
=== CONT TestAccEC2Instance_IPv6AddressCount
--- PASS: TestAccEC2Instance_IPv6_supportAddressCountWithIPv4 (182.15s)
--- PASS: TestAccEC2Instance_IPv6_supportAddressCount (170.51s)
--- PASS: TestAccEC2Instance_IPv6AddressCount (178.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 355.332s
@hfinucane Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This will allow adjusting the
ipv6_address_count
address on an instance's primary NIC without replacing the instance.Relations
Closes #33707
Output from Acceptance Testing