New resource: aws_costoptimizationhub_enrollment_status #36440

madhavvishnubhatta · 2024-03-18T17:29:37Z

Description

This change adds a new resource to Cost Optimization Hub

Relations

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/costoptimizationhub
https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_Operations_Cost_Optimization_Hub.html

Output from Acceptance Testing

bash-3.2$ make testacc PKG=costoptimizationhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/costoptimizationhub/... -v -count 1 -parallel 20   -timeout 360m
=== RUN   TestAccCostOptimizationHub_serial
=== PAUSE TestAccCostOptimizationHub_serial
=== RUN   TestEndpointConfiguration
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_config_file_overrides_base_config_file
=== RUN   TestEndpointConfiguration/no_config
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar
=== RUN   TestEndpointConfiguration/base_endpoint_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar
--- PASS: TestEndpointConfiguration (0.71s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.06s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.09s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.05s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/no_config (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.05s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.06s)
=== CONT  TestAccCostOptimizationHub_serial
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/basic
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts
--- PASS: TestAccCostOptimizationHub_serial (42.65s)
    --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus (42.65s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/basic (15.21s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears (13.73s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts (13.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/costoptimizationhub        48.111s

github-actions · 2024-03-18T17:31:23Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…ch resource separately.

YakDriver · 2024-09-11T19:34:52Z

I don't know if the service previously returned a value for includeMemberAccounts or not. However, the service no longer does in the AWS for Go SDK v2 nor in the AWS CLI:

% aws cost-optimization-hub update-enrollment-status --status Active --include-member-accounts
{
    "status": "Active"
}
% aws cost-optimization-hub list-enrollment-statuses
{
    "items": [
        {
            "accountId": "012345678901",
            "status": "Active",
            "lastUpdatedTimestamp": "2024-09-11T15:31:18.684000-04:00",
            "createdTimestamp": "2024-09-11T08:32:31.502000-04:00"
        }
    ],
    "includeMemberAccounts": null
}
% aws cost-optimization-hub update-enrollment-status --status Active --no-include-member-accounts
{
    "status": "Active"
}
% aws cost-optimization-hub list-enrollment-statuses
{
    "items": [
        {
            "accountId": "012345678901",
            "status": "Active",
            "lastUpdatedTimestamp": "2024-09-11T15:37:10.419000-04:00",
            "createdTimestamp": "2024-09-11T08:32:31.502000-04:00"
        }
    ],
    "includeMemberAccounts": null
}

YakDriver

Thanks for your work on this! LGTM 🎉

% make t K=costoptimizationhub 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/costoptimizationhub/... -v -count 1 -parallel 20   -timeout 360m
=== RUN   TestAccCostOptimizationHub_serial
=== PAUSE TestAccCostOptimizationHub_serial
=== RUN   TestEndpointConfiguration
=== RUN   TestEndpointConfiguration/base_endpoint_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_config_file_overrides_base_config_file
=== RUN   TestEndpointConfiguration/use_fips_config
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_config_file
=== RUN   TestEndpointConfiguration/no_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar
=== RUN   TestEndpointConfiguration/service_config_file
=== RUN   TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar
=== RUN   TestEndpointConfiguration/service_aws_envvar
--- PASS: TestEndpointConfiguration (0.60s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/use_fips_config (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.02s)
    --- PASS: TestEndpointConfiguration/no_config (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar (0.02s)
=== CONT  TestAccCostOptimizationHub_serial
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/basic
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts
--- PASS: TestAccCostOptimizationHub_serial (57.65s)
    --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus (57.65s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/basic (16.12s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears (16.62s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts (24.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/costoptimizationhub	63.344s

madhavvishnubhatta · 2024-09-12T07:52:38Z

I don't know if the service previously returned a value for includeMemberAccounts or not. However, the service no longer does in the AWS for Go SDK v2 nor in the AWS CLI:

includeMemberAccounts is returned with a value only on Management accounts. Not on member accounts. See below the output on a management account.

$ aws cost-optimization-hub update-enrollment-status --status Active --include-member-accounts
{
    "status": "Active"
}
$  aws cost-optimization-hub list-enrollment-statuses
{
    "items": [
        {
            "accountId": "012345678901",
            "createdTimestamp": "2024-01-19T11:33:44.570000+00:00",
            "lastUpdatedTimestamp": "2024-09-12T08:49:17.249000+01:00",
            "status": "Active"
        }
    ],
    "includeMemberAccounts": true
}
$ aws cost-optimization-hub update-enrollment-status --status Active --no-include-member-accounts
{
    "status": "Active"
}
$  aws cost-optimization-hub list-enrollment-statuses
{
    "items": [
        {
            "accountId": "012345678901",
            "createdTimestamp": "2024-01-19T11:33:44.570000+00:00",
            "lastUpdatedTimestamp": "2024-09-12T08:50:56.208000+01:00",
            "status": "Active"
        }
    ],
    "includeMemberAccounts": false
}

github-actions · 2024-09-13T00:39:42Z

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Mar 18, 2024

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2024

madhavvishnubhatta marked this pull request as ready for review March 19, 2024 09:37

github-actions bot added the generators Relates to code generators. label Mar 19, 2024

madhavvishnubhatta mentioned this pull request Mar 22, 2024

New resource: aws_costoptimizationhub_preferences #36526

Merged

YakDriver self-assigned this Sep 10, 2024

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 10, 2024

mvishnub added 8 commits September 10, 2024 17:52

Skaff Provided code

9a93087

Added the resource and acceptance tests.

bd38792

Cleaned up some comments, and lint findings.

52c7343

Added a single costoptimizationhub_test.go file to be able to test ea…

fb2f50b

…ch resource separately.

make gen commit

753a1db

Fixed terrafmt and semgrep findings

2b7ffc1

Added changelog entry

c35d3c2

Removed the unused flag unenroll_on_destroy

db0e1db

YakDriver force-pushed the f-aws_costoptimizationhub_enrollment_status branch from 3b1a939 to db0e1db Compare September 10, 2024 21:52

YakDriver requested a review from a team as a code owner September 10, 2024 21:52

YakDriver added 4 commits September 11, 2024 17:13

costoptimizationhub/docs: Update

bbba1b1

costoptimizationhub/enrollment_status: Add autoflex, fix for API quirk

38b106b

costoptimizationhub/tests: Minor updates

47b987d

coh: Lint fixes

e36817f

YakDriver changed the title ~~F aws costoptimizationhub enrollment status~~ New resource: aws_costoptimizationhub_enrollment_status Sep 11, 2024

YakDriver added 3 commits September 11, 2024 17:36

coh: Constants

2035fc0

coh/enrollment_status: Fix import, constants

29493e6

coh/enrollment_status/test: Use constants

a1fd32f

YakDriver approved these changes Sep 11, 2024

View reviewed changes

coh: Format fix

aa08c35

YakDriver merged commit d63599c into hashicorp:main Sep 11, 2024
40 checks passed

github-actions bot added this to the v5.67.0 milestone Sep 11, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_costoptimizationhub_enrollment_status #36440

New resource: aws_costoptimizationhub_enrollment_status #36440

madhavvishnubhatta commented Mar 18, 2024 •

edited

Loading

github-actions bot commented Mar 18, 2024

YakDriver commented Sep 11, 2024 •

edited

Loading

YakDriver left a comment •

edited

Loading

madhavvishnubhatta commented Sep 12, 2024

github-actions bot commented Sep 13, 2024

New resource: aws_costoptimizationhub_enrollment_status #36440

New resource: aws_costoptimizationhub_enrollment_status #36440

Conversation

madhavvishnubhatta commented Mar 18, 2024 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Mar 18, 2024

Community Note

YakDriver commented Sep 11, 2024 • edited Loading

YakDriver left a comment • edited Loading

Choose a reason for hiding this comment

madhavvishnubhatta commented Sep 12, 2024

github-actions bot commented Sep 13, 2024

madhavvishnubhatta commented Mar 18, 2024 •

edited

Loading

YakDriver commented Sep 11, 2024 •

edited

Loading

YakDriver left a comment •

edited

Loading