Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default RateLimiter is ratelimit.None #36467

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Default RateLimiter is ratelimit.None #36467

merged 4 commits into from
Mar 20, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 19, 2024

Description

Changes the default AWS SDK for Go v2 API client RateLimiter to ratelimit.None.

Relations

Closes #36024.
Closes #36094.
Closes #25552.

References

Requires aws-sdk-go-base@v2.0.0-beta.50.

Smoke test with newly migrated service

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccECRPublicRepository_' PKG=ecrpublic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ecrpublic/... -v -count 1 -parallel 20  -run=TestAccECRPublicRepository_ -timeout 360m
=== RUN   TestAccECRPublicRepository_basic
=== PAUSE TestAccECRPublicRepository_basic
=== RUN   TestAccECRPublicRepository_tags
=== PAUSE TestAccECRPublicRepository_tags
=== RUN   TestAccECRPublicRepository_CatalogData_aboutText
=== PAUSE TestAccECRPublicRepository_CatalogData_aboutText
=== RUN   TestAccECRPublicRepository_CatalogData_architectures
=== PAUSE TestAccECRPublicRepository_CatalogData_architectures
=== RUN   TestAccECRPublicRepository_CatalogData_description
=== PAUSE TestAccECRPublicRepository_CatalogData_description
=== RUN   TestAccECRPublicRepository_CatalogData_operatingSystems
=== PAUSE TestAccECRPublicRepository_CatalogData_operatingSystems
=== RUN   TestAccECRPublicRepository_CatalogData_usageText
=== PAUSE TestAccECRPublicRepository_CatalogData_usageText
=== RUN   TestAccECRPublicRepository_CatalogData_logoImageBlob
=== PAUSE TestAccECRPublicRepository_CatalogData_logoImageBlob
=== RUN   TestAccECRPublicRepository_Basic_forceDestroy
=== PAUSE TestAccECRPublicRepository_Basic_forceDestroy
=== RUN   TestAccECRPublicRepository_disappears
=== PAUSE TestAccECRPublicRepository_disappears
=== CONT  TestAccECRPublicRepository_basic
=== CONT  TestAccECRPublicRepository_CatalogData_operatingSystems
=== CONT  TestAccECRPublicRepository_CatalogData_description
=== CONT  TestAccECRPublicRepository_Basic_forceDestroy
=== CONT  TestAccECRPublicRepository_disappears
=== CONT  TestAccECRPublicRepository_CatalogData_usageText
=== CONT  TestAccECRPublicRepository_CatalogData_aboutText
=== CONT  TestAccECRPublicRepository_CatalogData_logoImageBlob
=== CONT  TestAccECRPublicRepository_tags
=== CONT  TestAccECRPublicRepository_CatalogData_architectures
--- PASS: TestAccECRPublicRepository_disappears (62.80s)
--- PASS: TestAccECRPublicRepository_Basic_forceDestroy (71.39s)
--- PASS: TestAccECRPublicRepository_basic (71.54s)
--- PASS: TestAccECRPublicRepository_CatalogData_logoImageBlob (72.55s)
--- PASS: TestAccECRPublicRepository_CatalogData_description (96.08s)
--- PASS: TestAccECRPublicRepository_CatalogData_operatingSystems (96.28s)
--- PASS: TestAccECRPublicRepository_CatalogData_aboutText (96.57s)
--- PASS: TestAccECRPublicRepository_CatalogData_usageText (96.62s)
--- PASS: TestAccECRPublicRepository_CatalogData_architectures (96.93s)
--- PASS: TestAccECRPublicRepository_tags (106.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic	117.519s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. labels Mar 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 19, 2024
@jar-b
Copy link
Member

jar-b commented Mar 20, 2024

#36476 has updated aws-sdk-go-base to 2.0.0-beta.50

@ewbankkit ewbankkit changed the title [WIP] Default RateLimiter is ratelimit.None Default RateLimiter is ratelimit.None Mar 20, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit ewbankkit merged commit 4374f88 into main Mar 20, 2024
64 checks passed
@ewbankkit ewbankkit deleted the f-ratelimit.None branch March 20, 2024 16:15
@github-actions github-actions bot added this to the v5.42.0 milestone Mar 20, 2024
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 22, 2024
Copy link

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants