Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unhealthy_node_replacement arg for aws_emr_cluster #36523

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Mar 22, 2024

Description

This PR is to add the new unhealthy_node_replacement argument to the aws_emr_cluster resource.

Relations

Closes #36433

References

Referred to RunJobFlow and SetUnhealthyNodeReplacement in the API reference doc.

Output from Acceptance Testing

Note: TestAccEMRCluster_unhealthyNodeReplacement is a new test case.

$ make testacc TESTS="TestAccEMRCluster_unhealthyNodeReplacement" PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRCluster_unhealthyNodeReplacement'  -timeout 360m
=== RUN   TestAccEMRCluster_unhealthyNodeReplacement
=== PAUSE TestAccEMRCluster_unhealthyNodeReplacement
=== CONT  TestAccEMRCluster_unhealthyNodeReplacement
--- PASS: TestAccEMRCluster_unhealthyNodeReplacement (940.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        940.710s

$

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. labels Mar 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 22, 2024
@acwwat acwwat force-pushed the f-aws_emr_cluster-add_unhealthy_node_replacement_arg branch from 2093ff7 to 34f9c41 Compare March 22, 2024 09:31
@acwwat acwwat changed the title [WIP] feat: Add unhealthy_node_replacement arg for aws_emr_cluster feat: Add unhealthy_node_replacement arg for aws_emr_cluster Mar 22, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 22, 2024
@ewbankkit ewbankkit added the external-maintainer Contribution from a trusted external contributor. label Apr 1, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRCluster_unhealthyNodeReplacement\|TestAccEMRCluster_basic' PKG=emr         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRCluster_unhealthyNodeReplacement\|TestAccEMRCluster_basic -timeout 360m
=== RUN   TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN   TestAccEMRCluster_unhealthyNodeReplacement
=== PAUSE TestAccEMRCluster_unhealthyNodeReplacement
=== CONT  TestAccEMRCluster_basic
=== CONT  TestAccEMRCluster_unhealthyNodeReplacement
--- PASS: TestAccEMRCluster_basic (299.05s)
--- PASS: TestAccEMRCluster_unhealthyNodeReplacement (714.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	726.032s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c2bada3 into hashicorp:main Apr 1, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.44.0 milestone Apr 1, 2024
@acwwat acwwat deleted the f-aws_emr_cluster-add_unhealthy_node_replacement_arg branch April 1, 2024 19:34
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented May 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/emr Issues and PRs that pertain to the emr service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for unhealthy-node-replacement to EMR cluster resource
3 participants