Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_costoptimizationhub_preferences #36526

Conversation

madhavvishnubhatta
Copy link
Contributor

Description

Adds a resource "Preferences" to the Cost Optimization Hub service.

Relations

Closes #34588

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/costoptimizationhub
https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_Operations_Cost_Optimization_Hub.html

#36440 is the first PR for this service. This is the second one.

Output from Acceptance Testing

$make testacc TESTARGS='-run=TestAccCostOptimizationHub_serial/Preferences' PKG=costoptimizationhub  ACCTEST_PARALLLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/costoptimizationhub/... -v -count 1 -parallel 1  -run=TestAccCostOptimizationHub_serial/Preferences -timeout 360m
=== RUN   TestAccCostOptimizationHub_serial
=== PAUSE TestAccCostOptimizationHub_serial
=== CONT  TestAccCostOptimizationHub_serial
=== RUN   TestAccCostOptimizationHub_serial/Preferences
=== RUN   TestAccCostOptimizationHub_serial/Preferences/basic
=== RUN   TestAccCostOptimizationHub_serial/Preferences/disappears
=== RUN   TestAccCostOptimizationHub_serial/Preferences/memberAccountsDiscountVisibility
=== RUN   TestAccCostOptimizationHub_serial/Preferences/savingsEstimationMode
--- PASS: TestAccCostOptimizationHub_serial (56.85s)
    --- PASS: TestAccCostOptimizationHub_serial/Preferences (56.85s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/basic (14.64s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/disappears (15.60s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/memberAccountsDiscountVisibility (13.24s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/savingsEstimationMode (13.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/costoptimizationhub        61.859s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. labels Mar 22, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Mar 22, 2024
@justinretzolk justinretzolk added new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 22, 2024
@madhavvishnubhatta madhavvishnubhatta marked this pull request as ready for review March 27, 2024 11:24
@YakDriver YakDriver self-assigned this Sep 10, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 10, 2024
@YakDriver YakDriver changed the title F aws costoptimizationhub preferences New resource: aws_costoptimizationhub_preferences Sep 12, 2024
@YakDriver YakDriver force-pushed the f-aws_costoptimizationhub_preferences branch from 218a231 to 7bae044 Compare September 12, 2024 13:19
@YakDriver YakDriver requested a review from a team as a code owner September 12, 2024 13:19
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

% make t T=TestAccCostOptimizationHub_serial K=costoptimizationhub
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/costoptimizationhub/... -v -count 1 -parallel 20 -run='TestAccCostOptimizationHub_serial'  -timeout 360m
=== RUN   TestAccCostOptimizationHub_serial
=== PAUSE TestAccCostOptimizationHub_serial
=== CONT  TestAccCostOptimizationHub_serial
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/basic
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears
=== RUN   TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts
=== RUN   TestAccCostOptimizationHub_serial/Preferences
=== RUN   TestAccCostOptimizationHub_serial/Preferences/basic
=== RUN   TestAccCostOptimizationHub_serial/Preferences/disappears
=== RUN   TestAccCostOptimizationHub_serial/Preferences/memberAccountsDiscountVisibility
=== RUN   TestAccCostOptimizationHub_serial/Preferences/savingsEstimationMode
--- PASS: TestAccCostOptimizationHub_serial (123.27s)
    --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus (57.05s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/basic (16.10s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/disappears (16.28s)
        --- PASS: TestAccCostOptimizationHub_serial/EnrollmentStatus/includeMemberAccounts (24.66s)
    --- PASS: TestAccCostOptimizationHub_serial/Preferences (66.22s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/basic (15.80s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/disappears (18.61s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/memberAccountsDiscountVisibility (15.89s)
        --- PASS: TestAccCostOptimizationHub_serial/Preferences/savingsEstimationMode (15.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/costoptimizationhub	128.029s

@YakDriver YakDriver force-pushed the f-aws_costoptimizationhub_preferences branch from 28f2e3a to 25cf1c1 Compare September 12, 2024 17:16
@YakDriver YakDriver merged commit ea4e6b9 into hashicorp:main Sep 12, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-service Introduces a new service. partner Contribution from a partner. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: AWS Cost Optimization Hub
3 participants