Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original_snapshot_create_time for aws_db_snapshot data source #36544

Conversation

msvbhat
Copy link
Contributor

@msvbhat msvbhat commented Mar 23, 2024

Description

Adds original_snapshot_create_time attribute to the aws_db_snapshot data source.

Relations

Closes #36543

References

The DescribeDBSnapshots API returns a list of DBSnapshot instances. And this object contains a field called OriginalSnapshotCreateTime. So far the data source aws_db_snapshot did not include this field. This PR adds it to the output of the data source with the attribute original_snapshot_create_time.

Output from Acceptance Testing

make testacc TESTS=TestAccRDSSnapshotDataSource PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSnapshotDataSource'  -timeout 360m
=== RUN   TestAccRDSSnapshotDataSource_basic
=== PAUSE TestAccRDSSnapshotDataSource_basic
=== CONT  TestAccRDSSnapshotDataSource_basic
--- PASS: TestAccRDSSnapshotDataSource_basic (596.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	601.712s

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels Mar 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 23, 2024
msvbhat added 2 commits March 23, 2024 21:34

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
They are generated and should not be edited directly

Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
@msvbhat msvbhat force-pushed the f-aws_db_snapshot-include-original-snapshot-create-time branch from 52a4769 to 552832b Compare March 23, 2024 20:42
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 25, 2024

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSSnapshotDataSource_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSSnapshotDataSource_basic -timeout 360m
=== RUN   TestAccRDSSnapshotDataSource_basic
=== PAUSE TestAccRDSSnapshotDataSource_basic
=== CONT  TestAccRDSSnapshotDataSource_basic
--- PASS: TestAccRDSSnapshotDataSource_basic (819.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	831.691s

@ewbankkit
Copy link
Contributor

@msvbhat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit efe33f8 into hashicorp:main Mar 25, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 25, 2024
@msvbhat msvbhat deleted the f-aws_db_snapshot-include-original-snapshot-create-time branch March 25, 2024 15:40
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add original_snapshot_create_time to aws_db_snapshot data source
2 participants