-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add original_snapshot_create_time for aws_db_snapshot data source #36544
Add original_snapshot_create_time for aws_db_snapshot data source #36544
Conversation
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Community NoteVoting for Prioritization
For Submitters
|
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
They are generated and should not be edited directly Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
52a4769
to
552832b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSSnapshotDataSource_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSSnapshotDataSource_basic -timeout 360m
=== RUN TestAccRDSSnapshotDataSource_basic
=== PAUSE TestAccRDSSnapshotDataSource_basic
=== CONT TestAccRDSSnapshotDataSource_basic
--- PASS: TestAccRDSSnapshotDataSource_basic (819.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 831.691s
@msvbhat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds
original_snapshot_create_time
attribute to theaws_db_snapshot
data source.Relations
Closes #36543
References
The DescribeDBSnapshots API returns a list of DBSnapshot instances. And this object contains a field called
OriginalSnapshotCreateTime
. So far the data sourceaws_db_snapshot
did not include this field. This PR adds it to the output of the data source with the attributeoriginal_snapshot_create_time
.Output from Acceptance Testing