-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appsync: Migrate to AWS SDK v2 #36568
appsync: Migrate to AWS SDK v2 #36568
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
This reverts commit 9c276d1.
…untime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs20.x) while creating or updating functions'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppSync' PKG=appsync ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appsync/... -v -count 1 -parallel 3 -run=TestAccAppSync -timeout 360m
=== RUN TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== RUN TestAccAppSyncDataSource_Elasticsearch_region
=== PAUSE TestAccAppSyncDataSource_Elasticsearch_region
=== RUN TestAccAppSyncDataSource_OpenSearchService_region
=== PAUSE TestAccAppSyncDataSource_OpenSearchService_region
=== RUN TestAccAppSyncDataSource_Type_elasticSearch
=== PAUSE TestAccAppSyncDataSource_Type_elasticSearch
=== RUN TestAccAppSyncDataSource_Type_openSearchService
=== PAUSE TestAccAppSyncDataSource_Type_openSearchService
=== CONT TestAccAppSync_serial
=== CONT TestAccAppSyncDataSource_Type_elasticSearch
=== CONT TestAccAppSyncDataSource_Type_openSearchService
=== RUN TestAccAppSync_serial/DomainName
=== RUN TestAccAppSync_serial/DomainName/disappears
domain_name_test.go:92: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set, skipping test
=== RUN TestAccAppSync_serial/DomainName/description
domain_name_test.go:56: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set, skipping test
=== RUN TestAccAppSync_serial/DomainName/basic
domain_name_test.go:25: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set, skipping test
=== RUN TestAccAppSync_serial/DataSource
=== RUN TestAccAppSync_serial/DataSource/Type_http_auth
=== RUN TestAccAppSync_serial/DataSource/Type_none
=== RUN TestAccAppSync_serial/DataSource/Type_rdbms
=== RUN TestAccAppSync_serial/DataSource/DynamoDB_useCallerCredentials
=== RUN TestAccAppSync_serial/DataSource/type
=== RUN TestAccAppSync_serial/DataSource/Type_http
=== RUN TestAccAppSync_serial/DataSource/HTTP_endpoint
=== RUN TestAccAppSync_serial/DataSource/Type_dynamoDB
=== RUN TestAccAppSync_serial/DataSource/Type_lambda
=== RUN TestAccAppSync_serial/DataSource/Type_rdbms_options
=== RUN TestAccAppSync_serial/DataSource/basic
=== RUN TestAccAppSync_serial/DataSource/description
=== RUN TestAccAppSync_serial/DataSource/DynamoDB_region
=== RUN TestAccAppSync_serial/DataSource/Type_eventBridge
=== RUN TestAccAppSync_serial/GraphQLAPI
=== RUN TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL
=== RUN TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools
=== RUN TestAccAppSync_serial/GraphQLAPI/disappears
=== RUN TestAccAppSync_serial/GraphQLAPI/schema
=== RUN TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds
=== RUN TestAccAppSync_serial/GraphQLAPI/visibility
=== RUN TestAccAppSync_serial/GraphQLAPI/resolverCountLimit
=== RUN TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda
=== RUN TestAccAppSync_serial/GraphQLAPI/name
=== RUN TestAccAppSync_serial/GraphQLAPI/log
=== RUN TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri
=== RUN TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda
=== RUN TestAccAppSync_serial/GraphQLAPI/tags
=== RUN TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect
=== RUN TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent
=== RUN TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction
=== RUN TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple
=== RUN TestAccAppSync_serial/GraphQLAPI/basic
=== RUN TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey
=== RUN TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM
=== RUN TestAccAppSync_serial/GraphQLAPI/introspectionConfig
=== RUN TestAccAppSync_serial/GraphQLAPI/queryDepthLimit
=== RUN TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression
=== RUN TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey
=== RUN TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel
=== RUN TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL
=== RUN TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID
=== RUN TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer
=== RUN TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion
=== RUN TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect
=== RUN TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM
=== RUN TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools
=== RUN TestAccAppSync_serial/GraphQLAPI/xrayEnabled
=== RUN TestAccAppSync_serial/GraphQLAPI/authenticationType
=== RUN TestAccAppSync_serial/Function
=== RUN TestAccAppSync_serial/Function/basic
=== RUN TestAccAppSync_serial/Function/code
=== RUN TestAccAppSync_serial/Function/disappears
=== RUN TestAccAppSync_serial/Function/description
=== RUN TestAccAppSync_serial/Function/responseMappingTemplate
=== RUN TestAccAppSync_serial/Function/sync
=== RUN TestAccAppSync_serial/Resolver
=== RUN TestAccAppSync_serial/Resolver/dataSource
=== RUN TestAccAppSync_serial/Resolver/DataSource_lambda
=== RUN TestAccAppSync_serial/Resolver/requestTemplate
=== RUN TestAccAppSync_serial/Resolver/pipeline
=== RUN TestAccAppSync_serial/Resolver/caching
=== RUN TestAccAppSync_serial/Resolver/disappears
=== RUN TestAccAppSync_serial/Resolver/code
=== RUN TestAccAppSync_serial/Resolver/responseTemplate
=== RUN TestAccAppSync_serial/Resolver/multipleResolvers
=== RUN TestAccAppSync_serial/Resolver/sync
=== RUN TestAccAppSync_serial/Resolver/basic
--- PASS: TestAccAppSyncDataSource_Type_elasticSearch (1627.56s)
=== CONT TestAccAppSyncDataSource_OpenSearchService_region
=== RUN TestAccAppSync_serial/APIKey
=== RUN TestAccAppSync_serial/APIKey/basic
=== RUN TestAccAppSync_serial/APIKey/description
=== RUN TestAccAppSync_serial/APIKey/expires
=== RUN TestAccAppSync_serial/ApiCache
=== RUN TestAccAppSync_serial/ApiCache/basic
--- PASS: TestAccAppSyncDataSource_Type_openSearchService (1853.98s)
=== CONT TestAccAppSyncDataSource_Elasticsearch_region
=== RUN TestAccAppSync_serial/ApiCache/disappears
=== RUN TestAccAppSync_serial/Type
=== RUN TestAccAppSync_serial/Type/basic
=== RUN TestAccAppSync_serial/Type/disappears
=== RUN TestAccAppSync_serial/DomainNameAssociation
=== RUN TestAccAppSync_serial/DomainNameAssociation/basic
domain_name_api_association_test.go:25: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set, skipping test
=== RUN TestAccAppSync_serial/DomainNameAssociation/disappears
domain_name_api_association_test.go:63: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set, skipping test
--- PASS: TestAccAppSync_serial (3302.07s)
--- PASS: TestAccAppSync_serial/DomainName (0.00s)
--- SKIP: TestAccAppSync_serial/DomainName/disappears (0.00s)
--- SKIP: TestAccAppSync_serial/DomainName/description (0.00s)
--- SKIP: TestAccAppSync_serial/DomainName/basic (0.00s)
--- PASS: TestAccAppSync_serial/DataSource (784.63s)
--- PASS: TestAccAppSync_serial/DataSource/Type_http_auth (12.21s)
--- PASS: TestAccAppSync_serial/DataSource/Type_none (11.34s)
--- PASS: TestAccAppSync_serial/DataSource/Type_rdbms (278.84s)
--- PASS: TestAccAppSync_serial/DataSource/DynamoDB_useCallerCredentials (31.18s)
--- PASS: TestAccAppSync_serial/DataSource/type (18.51s)
--- PASS: TestAccAppSync_serial/DataSource/Type_http (13.09s)
--- PASS: TestAccAppSync_serial/DataSource/HTTP_endpoint (20.76s)
--- PASS: TestAccAppSync_serial/DataSource/Type_dynamoDB (21.20s)
--- PASS: TestAccAppSync_serial/DataSource/Type_lambda (27.31s)
--- PASS: TestAccAppSync_serial/DataSource/Type_rdbms_options (278.71s)
--- PASS: TestAccAppSync_serial/DataSource/basic (12.27s)
--- PASS: TestAccAppSync_serial/DataSource/description (18.44s)
--- PASS: TestAccAppSync_serial/DataSource/DynamoDB_region (28.39s)
--- PASS: TestAccAppSync_serial/DataSource/Type_eventBridge (12.40s)
--- PASS: TestAccAppSync_serial/GraphQLAPI (458.63s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL (18.47s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools (14.36s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/disappears (10.11s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/schema (23.08s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds (51.96s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/visibility (11.58s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/resolverCountLimit (11.61s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda (28.31s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/name (16.62s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/log (12.49s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri (38.49s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda (27.60s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/tags (24.11s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect (11.88s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent (19.52s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction (21.80s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple (28.17s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/basic (11.12s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey (11.01s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM (11.42s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/introspectionConfig (10.97s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/queryDepthLimit (11.22s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression (37.60s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey (10.65s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel (25.39s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL (17.01s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID (17.55s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer (17.58s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion (19.72s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect (11.18s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM (10.88s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools (13.54s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/xrayEnabled (15.63s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/authenticationType (17.47s)
--- PASS: TestAccAppSync_serial/Function (157.07s)
--- PASS: TestAccAppSync_serial/Function/basic (32.66s)
--- PASS: TestAccAppSync_serial/Function/code (20.28s)
--- PASS: TestAccAppSync_serial/Function/disappears (27.40s)
--- PASS: TestAccAppSync_serial/Function/description (31.33s)
--- PASS: TestAccAppSync_serial/Function/responseMappingTemplate (23.37s)
--- PASS: TestAccAppSync_serial/Function/sync (22.04s)
--- PASS: TestAccAppSync_serial/Resolver (227.56s)
--- PASS: TestAccAppSync_serial/Resolver/dataSource (27.68s)
--- PASS: TestAccAppSync_serial/Resolver/DataSource_lambda (27.70s)
--- PASS: TestAccAppSync_serial/Resolver/requestTemplate (22.20s)
--- PASS: TestAccAppSync_serial/Resolver/pipeline (16.76s)
--- PASS: TestAccAppSync_serial/Resolver/caching (15.70s)
--- PASS: TestAccAppSync_serial/Resolver/disappears (14.47s)
--- PASS: TestAccAppSync_serial/Resolver/code (17.03s)
--- PASS: TestAccAppSync_serial/Resolver/responseTemplate (25.00s)
--- PASS: TestAccAppSync_serial/Resolver/multipleResolvers (21.30s)
--- PASS: TestAccAppSync_serial/Resolver/sync (22.24s)
--- PASS: TestAccAppSync_serial/Resolver/basic (17.48s)
--- PASS: TestAccAppSync_serial/APIKey (53.59s)
--- PASS: TestAccAppSync_serial/APIKey/basic (12.69s)
--- PASS: TestAccAppSync_serial/APIKey/description (20.37s)
--- PASS: TestAccAppSync_serial/APIKey/expires (20.53s)
--- PASS: TestAccAppSync_serial/ApiCache (1598.29s)
--- PASS: TestAccAppSync_serial/ApiCache/basic (801.81s)
--- PASS: TestAccAppSync_serial/ApiCache/disappears (796.48s)
--- PASS: TestAccAppSync_serial/Type (22.29s)
--- PASS: TestAccAppSync_serial/Type/basic (11.94s)
--- PASS: TestAccAppSync_serial/Type/disappears (10.35s)
--- PASS: TestAccAppSync_serial/DomainNameAssociation (0.00s)
--- SKIP: TestAccAppSync_serial/DomainNameAssociation/basic (0.00s)
--- SKIP: TestAccAppSync_serial/DomainNameAssociation/disappears (0.00s)
--- PASS: TestAccAppSyncDataSource_OpenSearchService_region (1840.77s)
--- PASS: TestAccAppSyncDataSource_Elasticsearch_region (1887.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appsync 3745.883s
@mattburgess Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36118
References
Output from Acceptance Testing