Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key_value_store_associations to aws_cloudfront_function #36585

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Mar 26, 2024

Description

This PR uses the commits on another PR #36228 , and adds the ability to associate aws_cloudfront_key_value_store to an aws_cloudfront_function .

Relations

Closes #36048
Closes #35889
Closes #36228

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCloudFrontFunction_' PKG=cloudfront 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20  -run=TestAccCloudFrontFunction_ -timeout 360m
=== RUN   TestAccCloudFrontFunction_basic
=== PAUSE TestAccCloudFrontFunction_basic
=== RUN   TestAccCloudFrontFunction_disappears
=== PAUSE TestAccCloudFrontFunction_disappears
=== RUN   TestAccCloudFrontFunction_publish
=== PAUSE TestAccCloudFrontFunction_publish
=== RUN   TestAccCloudFrontFunction_associated
=== PAUSE TestAccCloudFrontFunction_associated
=== RUN   TestAccCloudFrontFunction_Update_code
=== PAUSE TestAccCloudFrontFunction_Update_code
=== RUN   TestAccCloudFrontFunction_UpdateCodeAndPublish
=== PAUSE TestAccCloudFrontFunction_UpdateCodeAndPublish
=== RUN   TestAccCloudFrontFunction_Update_comment
=== PAUSE TestAccCloudFrontFunction_Update_comment
=== RUN   TestAccCloudFrontFunction_KeyValueStoreAssociations
=== PAUSE TestAccCloudFrontFunction_KeyValueStoreAssociations
=== CONT  TestAccCloudFrontFunction_basic
=== CONT  TestAccCloudFrontFunction_Update_code
=== CONT  TestAccCloudFrontFunction_Update_comment
=== CONT  TestAccCloudFrontFunction_KeyValueStoreAssociations
=== CONT  TestAccCloudFrontFunction_associated
=== CONT  TestAccCloudFrontFunction_disappears
=== CONT  TestAccCloudFrontFunction_UpdateCodeAndPublish
=== CONT  TestAccCloudFrontFunction_publish
--- PASS: TestAccCloudFrontFunction_disappears (19.63s)
--- PASS: TestAccCloudFrontFunction_basic (21.87s)
--- PASS: TestAccCloudFrontFunction_UpdateCodeAndPublish (33.33s)
--- PASS: TestAccCloudFrontFunction_publish (33.46s)
--- PASS: TestAccCloudFrontFunction_Update_code (37.44s)
--- PASS: TestAccCloudFrontFunction_Update_comment (47.80s)
--- PASS: TestAccCloudFrontFunction_KeyValueStoreAssociations (88.13s)
--- PASS: TestAccCloudFrontFunction_associated (505.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 510.568s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 26, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Mar 26, 2024
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Mar 26, 2024
@brittandeyoung brittandeyoung added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 26, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 26, 2024
@ewbankkit ewbankkit self-assigned this Mar 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 26, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFrontFunction_\|TestAccCloudFrontFunctionDataSource_' PKG=cloudfront ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/cloudfront/... -v -count 1 -parallel 3  -run=TestAccCloudFrontFunction_\|TestAccCloudFrontFunctionDataSource_ -timeout 360m
=== RUN   TestAccCloudFrontFunctionDataSource_basic
=== PAUSE TestAccCloudFrontFunctionDataSource_basic
=== RUN   TestAccCloudFrontFunction_basic
=== PAUSE TestAccCloudFrontFunction_basic
=== RUN   TestAccCloudFrontFunction_disappears
=== PAUSE TestAccCloudFrontFunction_disappears
=== RUN   TestAccCloudFrontFunction_publish
=== PAUSE TestAccCloudFrontFunction_publish
=== RUN   TestAccCloudFrontFunction_associated
=== PAUSE TestAccCloudFrontFunction_associated
=== RUN   TestAccCloudFrontFunction_Update_code
=== PAUSE TestAccCloudFrontFunction_Update_code
=== RUN   TestAccCloudFrontFunction_UpdateCodeAndPublish
=== PAUSE TestAccCloudFrontFunction_UpdateCodeAndPublish
=== RUN   TestAccCloudFrontFunction_Update_comment
=== PAUSE TestAccCloudFrontFunction_Update_comment
=== RUN   TestAccCloudFrontFunction_KeyValueStoreAssociations
=== PAUSE TestAccCloudFrontFunction_KeyValueStoreAssociations
=== CONT  TestAccCloudFrontFunctionDataSource_basic
=== CONT  TestAccCloudFrontFunction_Update_code
=== CONT  TestAccCloudFrontFunction_Update_comment
--- PASS: TestAccCloudFrontFunctionDataSource_basic (41.84s)
=== CONT  TestAccCloudFrontFunction_UpdateCodeAndPublish
--- PASS: TestAccCloudFrontFunction_Update_code (48.20s)
=== CONT  TestAccCloudFrontFunction_publish
--- PASS: TestAccCloudFrontFunction_Update_comment (49.15s)
=== CONT  TestAccCloudFrontFunction_associated
--- PASS: TestAccCloudFrontFunction_UpdateCodeAndPublish (44.07s)
=== CONT  TestAccCloudFrontFunction_disappears
--- PASS: TestAccCloudFrontFunction_publish (40.88s)
=== CONT  TestAccCloudFrontFunction_KeyValueStoreAssociations
--- PASS: TestAccCloudFrontFunction_disappears (20.97s)
=== CONT  TestAccCloudFrontFunction_basic
--- PASS: TestAccCloudFrontFunction_basic (27.52s)
--- PASS: TestAccCloudFrontFunction_KeyValueStoreAssociations (97.23s)
--- PASS: TestAccCloudFrontFunction_associated (542.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	604.036s

@ewbankkit
Copy link
Contributor

@brittandeyoung @surajsubramanian Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6c1b1f7 into hashicorp:main Mar 27, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 27, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants