ASG check instance protection

[bstriner]

See #36584

Fix regression on ASG destruction. Only call SetInstanceProtection on instances that are protected.

Description

Re-incorporate logic from #23187

Relations

Closes #36584

References

#23187

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @bstriner 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[bstriner]

I think I would describe this as fixing a regression on expected and previous behavior. It should only matter when the deployer is trying to use least privilege. Happy to make any CHANGELOG changes if that seems warranted. Cheers!

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_InstanceRefresh_basic\|TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn\|TestAccAutoScalingGroup_basic' PKG=autoscaling         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_InstanceRefresh_basic\|TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn\|TestAccAutoScalingGroup_basic -timeout 360m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn
=== PAUSE TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
--- PASS: TestAccAutoScalingGroup_basic (63.00s)
--- PASS: TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn (187.39s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (342.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	354.515s

[ewbankkit]

@bstriner Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.